Repository navigation
Tests: Add unit coverage for rest_cookie_collect_status() - #15293
shail-mehta wants to merge 1 commit into
Conversation
Add unit tests for REST auth cookie status collection on valid and failure actions. See #65819.
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the test-only addition covering REST cookie status collection.
No open issues 🎉
What changed in this PR
Adds dedicated PHPUnit coverage for rest_cookie_collect_status() as part of the #65819 test cleanup effort. No production code changes.
Changes:
- Verifies that
auth_cookie_validsets the cookie status totrue. - Uses a data provider to check malformed, expired, bad-username, and bad-hash statuses.
- Adds
@coversmetadata and clears the status global during teardown.
| File | Description |
|---|---|
tests/phpunit/tests/rest-api/restCookieCollectStatus.php |
Adds tests for valid-cookie and failure-status collection. |
Review effort: Balanced
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. Props Bot commandsYou can trigger Props Bot actions by commenting on this PR:
|
lancewillett
left a comment
There was a problem hiding this comment.
Asserts the cookie-status callback converts auth success to boolean true and failure action names to meaningful status strings. This checks WordPress callback behavior, not just hook execution.
Local randomized single-site and multisite checks passed alongside related existing tests; PHPCS passed.
Optional: Four failure rows share one substring branch; one representative failure can suffice unless preserving registration coverage is intentional. No further failure matrix.
AI review · gpt-6
Verify `rest_cookie_collect_status()` records successful authentication and the failure status associated with cookie validation actions. Developed in: #15293 Props shailu25. See #65819. git-svn-id: https://develop.svn.wordpress.org/trunk@65143 602fd350-edb4-49c9-b593-d223f7449a82
Verify `rest_cookie_collect_status()` records successful authentication and the failure status associated with cookie validation actions. Developed in: WordPress/wordpress-develop#15293 Props shailu25. See #65819. Built from https://develop.svn.wordpress.org/trunk@65143 git-svn-id: http://core.svn.wordpress.org/trunk@64292 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
PR #15293 landed in https://core.trac.wordpress.org/changeset/65143 |
Trac ticket: #65819
What
Adds a dedicated PHPUnit class for
rest_cookie_collect_status(), covering the valid-cookie status and failure statuses collected from auth cookie actions.Test-only; no production code changes.
Why
rest_cookie_collect_status()had no direct@coverscoverage. Small helper coverage fits the #65819 test cleanup track.How
Add
tests/phpunit/tests/rest-api/restCookieCollectStatus.phpwith@covers ::rest_cookie_collect_status.$wp_rest_auth_cookietotrueonauth_cookie_validmalformed,expired,bad_username, andbad_hashTesting Instructions
npm run test:php -- --filter Tests_REST_API_RestCookieCollectStatusnpm run test:php -- --filter Tests_REST_API_RestCookieCollectStatus -c tests/phpunit/multisite.xmlnpm run test:php -- --filter Tests_REST_API_RestCookieCollectStatus --order-by=randomnpm run test:php -- --group restapiUse of AI Tools