Skip to content

Tests: Add unit coverage for rest_get_queried_resource_route() - #15291

Closed
shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:tests/rest-get-queried-resource-route-65819
Closed

shail-mehta wants to merge 2 commits into
WordPress:trunkfrom
shail-mehta:tests/rest-get-queried-resource-route-65819

Conversation

@shail-mehta

Copy link
Copy Markdown
Member

Trac ticket: #65819

What

Adds a dedicated PHPUnit class for rest_get_queried_resource_route(), covering singular posts, category archives, author archives, the empty fallback, and filter overrides.

Test-only; no production code changes.

Why

rest_get_queried_resource_route() had no direct @covers coverage. Small helper coverage fits the #65819 test cleanup track.

How

Add tests/phpunit/tests/rest-api/restGetQueriedResourceRoute.php with @covers ::rest_get_queried_resource_route.

  • Returns the post route on a singular query
  • Returns the category route on a category archive
  • Returns the user route on an author archive
  • Returns an empty string when no resource is identified
  • Allows rest_queried_resource_route to replace the route and asserts the original argument

Testing Instructions

  1. npm run test:php -- --filter Tests_REST_API_RestGetQueriedResourceRoute
  2. npm run test:php -- --filter Tests_REST_API_RestGetQueriedResourceRoute -c tests/phpunit/multisite.xml
  3. npm run test:php -- --filter Tests_REST_API_RestGetQueriedResourceRoute --order-by=random
  4. npm run test:php -- --group restapi

Use of AI Tools

  • Cursor

Add unit tests for queried post, term, and author REST routes, empty fallback, and filter overrides.

See #65819.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the test-only addition of direct PHPUnit coverage for rest_get_queried_resource_route().

No open issues 🎉

What changed in this PR

Adds direct PHPUnit coverage for rest_get_queried_resource_route() as part of the #65819 test cleanup effort. This is a test-only change; production code is unchanged.

Changes:

  • Tests routes for singular posts, category archives, and author archives.
  • Checks the empty-string fallback when no resource is identified.
  • Verifies filter overrides and the original route passed to the filter.
File Description
tests/​phpunit/​tests/​rest-api/​restGetQueriedResourceRoute.php Adds a dedicated test class with five cases and an explicit @covers annotation.

Review effort: Balanced

@shail-mehta
shail-mehta marked this pull request as ready for review October 31, 2026 17:20
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.


Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exercises query-to-REST-route selection for post, category, author and no-resource branches; these are not duplicates of direct route-builder tests.

Local randomized single-site and multisite checks passed alongside related existing tests; PHPCS passed.

Optional: No additional taxonomy/archive matrix needed; five methods cover the branches without per-taxonomy clones.

AI review · gpt-6

wporg-sync pushed a commit that referenced this pull request Oct 31, 2026
Verify `rest_get_queried_resource_route()` identifies singular posts, categories, and authors, handles requests without a resource, and respects its filter.

Developed in: #15291

Props shailu25.
See #65819.


git-svn-id: https://develop.svn.wordpress.org/trunk@65142 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 31, 2026
Verify `rest_get_queried_resource_route()` identifies singular posts, categories, and authors, handles requests without a resource, and respects its filter.

Developed in: WordPress/wordpress-develop#15291

Props shailu25.
See #65819.

Built from https://develop.svn.wordpress.org/trunk@65142


git-svn-id: http://core.svn.wordpress.org/trunk@64291 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@lancewillett

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants