[shail-mehta]

Trac ticket: #65819

What

Adds a dedicated PHPUnit class for get_comment_author_IP() and comment_author_IP(), covering IP retrieval, comment objects, the global comment fallback, empty IPs, the filter, and escaped output.

Test-only; no production code changes.

Why

These helpers had no direct @covers coverage. Small helper coverage fits the #65819 test cleanup track.

How

Add tests/phpunit/tests/comment/getCommentAuthorIP.php with @covers for both functions.

Testing Instructions

1. npm run test:php -- --filter Tests_Comment_GetCommentAuthorIP
2. npm run test:php -- --filter Tests_Comment_GetCommentAuthorIP -c tests/phpunit/multisite.xml
3. npm run test:php -- --filter Tests_Comment_GetCommentAuthorIP --order-by=random
4. npm run test:php -- --group comment

Use of AI Tools

• Cursor

[Copilot]

🟡 Changes recommended

The escaping test uses a value without HTML-special characters, so it would still pass if esc_html() were removed and would not detect an escaping regression.

1 open issue

• Test comment author IP escaping with HTML-special characters · New

What changed in this PR

Adds dedicated PHPUnit coverage for get_comment_author_IP() and comment_author_IP() as part of the #65819 test cleanup effort. No production code changes.

Changes:

• Tests IP retrieval by comment ID, comment object, and global fallback, including empty IPs.
• Tests filter customization and echoed output, with @covers annotations for both helpers.

File	Description
tests/​phpunit/​tests/​comment/​getCommentAuthorIP.php	Adds fixtures and six tests for comment-author IP helpers.

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues block the added PHPUnit coverage for the comment-author IP helpers.

No open issues 🎉

1 resolved since last review

• Test comment author IP escaping with HTML-special characters

_{Review effort: Balanced}

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

---

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

• @propsbot add <username> to give props to a GitHub user. Requires write access.
• @propsbot remove <username> to leave a user out of the props. Requires write access.
• @propsbot refresh to refresh this list. Adding the props-bot label works too.

[lancewillett]

The updated escaping test now catches a real escaping regression. Please trim the surrounding field-read matrix: the ID, object, global, and empty-IP cases repeat retrieval of the fixture value. Keep one representative getter case, the filter override, and the escaped-output case. This gives three focused checks without losing the escaping coverage. The current suite passes locally; this request is about keeping the new coverage proportionate.

_{AI review · gpt-6}

[Copilot]

🟡 Changes recommended

The tests leave comment-object input, global-comment fallback, and empty-IP behavior untested for both helpers, allowing regressions in these supported cases to go undetected.

1 open issue

• Add coverage for supported comment and empty-IP cases · New

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The tests cover only explicit comment IDs with non-empty IPs, leaving comment-object input, global-comment fallback, and empty-IP retrieval/output untested.

1 open issue

• Add coverage for comment-object, global fallback, and empty-IP cases · New

1 resolved since last review

• Add coverage for supported comment and empty-IP cases

_{Review effort: Balanced}

[shail-mehta]

Thanks @lancewillett - addressed your feedback: one representative getter, the filter override, and the escaped-output check.

Copilot asked to restore comment-object, global fallback, and empty-IP cases; leaving those out as the repetitive field-read matrix you asked to trim.

Happy to change further if needed.