Skip to content

REST API: Remove the temporary file when a raw-body upload fails the size check. #15134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erycson wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

REST API: Remove the temporary file when a raw-body upload fails the size check. #15134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
74f05b7
REST API: Remove the temporary file when a raw-body upload fails the …
erycson Oct 29, 2026
2808fd7
Merge branch 'trunk' into fix/rest-upload-temp-file
erycson Oct 30, 2026
172eb4a
Merge branch 'trunk' into fix/rest-upload-temp-file
erycson Oct 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-attachments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2052,6 +2052,8 @@ protected function upload_from_data( $data, $headers, $time = null ) {

$size_check = self::check_upload_size( $file_data );
if ( is_wp_error( $size_check ) ) {
@unlink( $tmpfname );

return $size_check;
}

Expand Down
22 changes: 22 additions & 0 deletions tests/phpunit/tests/rest-api/rest-attachments-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2789,6 +2789,28 @@ public function test_create_item_with_data_exceeds_multisite_max_filesize() {
$this->assertErrorResponse( 'rest_upload_file_too_big', $response, 400 );
}

/**
* @ticket 66409
* @group multisite
* @group ms-required
*/
public function test_create_item_with_data_exceeds_multisite_max_filesize_removes_temp_file() {
wp_set_current_user( self::$author_id );
update_site_option( 'fileupload_maxk', 1 );
update_site_option( 'upload_space_check_disabled', false );

$temp_files = glob( get_temp_dir() . 'canola-*.tmp' );

$request = new WP_REST_Request( 'POST', '/wp/v2/media' );
$request->set_header( 'Content-Type', 'image/jpeg' );
$request->set_header( 'Content-Disposition', 'attachment; filename=canola.jpg' );
$request->set_body( file_get_contents( self::$test_file ) );

$response = rest_get_server()->dispatch( $request );
$this->assertErrorResponse( 'rest_upload_file_too_big', $response, 400 );
$this->assertSame( $temp_files, glob( get_temp_dir() . 'canola-*.tmp' ), 'The temporary file should be removed when the upload is rejected.' );
}

/**
* @ticket 43751
* @group multisite
Expand Down
Loading