Skip to content

Tests: Add unit tests for wp_ajax_menu_locations_save() - #11899

Closed
pbearne wants to merge 5 commits into
WordPress:trunkfrom
pbearne:65252-ajax-actions-menu_locations_save
Closed

Tests: Add unit tests for wp_ajax_menu_locations_save()#11899
pbearne wants to merge 5 commits into
WordPress:trunkfrom
pbearne:65252-ajax-actions-menu_locations_save

Conversation

@pbearne

@pbearne pbearne commented May 20, 2026

Copy link
Copy Markdown

This PR adds unit tests for the wp_ajax_menu_locations_save() function located in src/wp-admin/includes/ajax-actions.php.

The tests cover:

  • Successful saving of menu locations in theme modifications.
  • Proper handling of invalid nonces (add-menu_item nonce).
  • Verification of user permissions (edit_theme_options capability).
  • Correct behavior when the menu-locations parameter is missing.

Trac ticket: https://core.trac.wordpress.org/ticket/65252

AI Disclosure:

  • AI assistance: Yes
  • Tool(s): Junie (JetBrains)
  • Model(s): gemini-3-flash-preview
  • Used for: Code analysis, test implementation, and workflow management.

Paul Bearne @junie-agent
Tests: Add unit tests for wp_ajax_menu_locations_save()
488d884 
Co-authored-by: Junie <junie@jetbrains.com>
@github-actions

github-actions Bot commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @junie-agent.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

  • @propsbot add <username> to give props to a GitHub user. Requires write access.
  • @propsbot remove <username> to leave a user out of the props. Requires write access.
  • @propsbot refresh to refresh this list. Adding the props-bot label works too.

@github-actions

github-actions Bot commented May 20, 2026

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@lancewillett
lancewillett requested a balanced review from Copilot October 29, 2026 23:39
Copilot AI reviewed Oct 29, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The AJAX test can pass when the handler returns without wp_die( 1 ), leaving the required success-response termination untested.

1 open issue
What changed in this PR

This PR adds unit tests for WordPress’s wp_ajax_menu_locations_save() handler without changing production code.

Changes:

  • Tests saving menu locations to theme modifications.
  • Tests rejection of invalid nonces and users without sufficient permissions.
  • Tests handling of a missing menu-locations parameter.
File Description
tests/​phpunit/​tests/​admin/​includes/​ajax-actions/​menuLocationsSave.php Adds user fixtures and four tests covering successful saves and rejected requests.

Review effort: Balanced

Comment thread tests/phpunit/tests/admin/includes/ajax-actions/menuLocationsSave.php
);

try {
$this->_handleAjax( 'menu-locations-save' );
lancewillett
lancewillett approved these changes Oct 29, 2026
View reviewed changes

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The saved menu ID and rejection cases cover the handler's useful behavior. This PR's cases passed in the supplied local single-site and multisite runs. Current CI is not verified green; this is code approval only.

AI review · gpt-6

@lancewillett

lancewillett commented Oct 31, 2026

Copy link
Copy Markdown
Member

@pbearne The patch passes local randomized PHPUnit checks against current trunk in single-site and multisite, plus PHP lint and coding standards.

The remaining failed checks are from June. Their logs have expired, and GitHub rejected a job rerun because the run is over a month old. I cannot establish the cause from the retained metadata. Could you refresh this branch against trunk to produce a current CI run before landing?

AI review · gpt-6

wporg-sync pushed a commit that referenced this pull request Oct 31, 2026
@lancewillett
Tests: Cover AJAX menu, editor and preference actions.
6ea8c0a 
Verify menu metabox output and saved menu locations, dismissed pointers, fullscreen post updates, and post-lock ownership and expiry. Cover relevant permission and nonce rejection paths.

Developed in: #11897, #11899, #12138

Props pbearne, ugyensupport.
See #65252.


git-svn-id: https://develop.svn.wordpress.org/trunk@65152 602fd350-edb4-49c9-b593-d223f7449a82
wporg-sync pushed a commit to WordPress/WordPress that referenced this pull request Oct 31, 2026
@lancewillett
Tests: Cover AJAX menu, editor and preference actions.
c057724 
Verify menu metabox output and saved menu locations, dismissed pointers, fullscreen post updates, and post-lock ownership and expiry. Cover relevant permission and nonce rejection paths.

Developed in: WordPress/wordpress-develop#11897, WordPress/wordpress-develop#11899, WordPress/wordpress-develop#12138

Props pbearne, ugyensupport.
See #65252.

Built from https://develop.svn.wordpress.org/trunk@65152


git-svn-id: http://core.svn.wordpress.org/trunk@64301 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@lancewillett

lancewillett commented Oct 31, 2026

Copy link
Copy Markdown
Member

PR #11899 landed in https://core.trac.wordpress.org/changeset/65152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@lancewillett lancewillett lancewillett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pbearne @lancewillett