Tests: Add unit tests for wp_ajax_menu_get_metabox() by pbearne · Pull Request #11897 · WordPress/wordpress-develop

pbearne · 2026-05-20T16:56:25Z

This PR adds unit tests for the wp_ajax_menu_get_metabox() function located in src/wp-admin/includes/ajax-actions.php.

The tests cover:

Successful retrieval of post type metaboxes (e.g., for 'post').
Successful retrieval of taxonomy metaboxes (e.g., for 'category').
Proper handling of insufficient user permissions (verification of edit_theme_options capability).
Validation of input parameters (item-type and item-object).

Trac ticket: https://core.trac.wordpress.org/ticket/65252

AI Disclosure:

AI assistance: Yes
Tool(s): Junie (JetBrains)
Model(s): gemini-3-flash-preview
Used for: Code analysis, test implementation, and workflow management.

Co-authored-by: Junie <junie@jetbrains.com>

github-actions · 2026-05-20T16:58:55Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @junie-agent.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core Committers: Use this line as a base for the props when committing in SVN:

Props pbearne, lancewillett.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Props Bot commands

You can trigger Props Bot actions by commenting on this PR:

@propsbot add <username> to give props to a GitHub user. Requires write access.
@propsbot remove <username> to leave a user out of the props. Requires write access.
@propsbot refresh to refresh this list. Adding the props-bot label works too.

github-actions · 2026-05-20T17:17:26Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copilot

🟡 Changes recommended

The invalid-item AJAX tests can pass despite nonempty wp_die() errors because they do not assert that the caught exception messages are empty.

1 open issue

Assert wp_die exception messages are empty for invalid AJAX items · New

What changed in this PR

Adds unit tests for WordPress’s wp_ajax_menu_get_metabox() handler without changing production code.

Changes:

Covers successful post type and taxonomy metabox retrieval.
Checks rejection of users without sufficient permissions.
Exercises invalid item-type and item-object inputs.

File	Description
`tests/phpunit/tests/admin/includes/ajax-actions/menuGetMetabox.php`	Adds fixtures and five tests covering metabox retrieval, permissions, and invalid inputs.

_{Review effort: Balanced}

+		} catch ( WPAjaxDieStopException $e ) {
+			// We expect it to die without outputting anything if item-type is invalid.


lancewillett

Post-type, taxonomy, and permission checks cover distinct behavior. The unused post fixture is optional cleanup. This PR's cases passed in the supplied local single-site and multisite runs. Current CI is not verified green; this is code approval only.

_{AI review · gpt-6}

lancewillett · 2026-10-31T20:14:41Z

@pbearne The patch passes local randomized PHPUnit checks against current trunk in single-site and multisite, plus PHP lint and coding standards.

The remaining failed checks are from June. Their logs have expired, and GitHub rejected a job rerun because the run is over a month old. I cannot establish the cause from the retained metadata. Could you refresh this branch against trunk to produce a current CI run before landing?

_{AI review · gpt-6}

Verify menu metabox output and saved menu locations, dismissed pointers, fullscreen post updates, and post-lock ownership and expiry. Cover relevant permission and nonce rejection paths. Developed in: #11897, #11899, #12138 Props pbearne, ugyensupport. See #65252. git-svn-id: https://develop.svn.wordpress.org/trunk@65152 602fd350-edb4-49c9-b593-d223f7449a82

Verify menu metabox output and saved menu locations, dismissed pointers, fullscreen post updates, and post-lock ownership and expiry. Cover relevant permission and nonce rejection paths. Developed in: WordPress/wordpress-develop#11897, WordPress/wordpress-develop#11899, WordPress/wordpress-develop#12138 Props pbearne, ugyensupport. See #65252. Built from https://develop.svn.wordpress.org/trunk@65152 git-svn-id: http://core.svn.wordpress.org/trunk@64301 1a063a9b-81f0-0310-95a4-ce76da25c4cd

lancewillett · 2026-10-31T21:19:14Z

PR #11897 landed in https://core.trac.wordpress.org/changeset/65152

Tests: Add unit tests for wp_ajax_menu_get_metabox()

19a5a06

Co-authored-by: Junie <junie@jetbrains.com>

Paul Bearne and others added 4 commits May 20, 2026 13:43

Tests: Fix exception handling in menuGetMetabox tests

624fa07

Merge branch 'trunk' into 65252-ajax-actions-menu_get_metabox

a561b3e

Tests: Fix metabox markup assertions in menuGetMetabox tests

ece807f

Merge branch 'trunk' into 65252-ajax-actions-menu_get_metabox

1619faf

pento force-pushed the trunk branch from 3af2d27 to 64ede28 Compare July 6, 2026 03:10

lancewillett requested a balanced review from Copilot October 29, 2026 23:39

Copilot started reviewing on behalf of lancewillett October 29, 2026 23:40

View session

Copilot AI reviewed Oct 29, 2026

View reviewed changes

Comment thread tests/phpunit/tests/admin/includes/ajax-actions/menuGetMetabox.php

Comment on lines +143 to +144

} catch ( WPAjaxDieStopException $e ) {

// We expect it to die without outputting anything if item-type is invalid.

lancewillett approved these changes Oct 29, 2026

View reviewed changes

Merge branch 'trunk' into 65252-ajax-actions-menu_get_metabox

d4c5143

lancewillett closed this Oct 31, 2026

Navigation Menu

Repository navigation

Tests: Add unit tests for wp_ajax_menu_get_metabox() - #11897

Tests: Add unit tests for wp_ajax_menu_get_metabox()#11897
pbearne wants to merge 6 commits into
WordPress:trunkfrom
pbearne:65252-ajax-actions-menu_get_metabox

pbearne commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

lancewillett left a comment

Uh oh!

lancewillett commented Oct 31, 2026

Uh oh!

lancewillett commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		} catch ( WPAjaxDieStopException $e ) {
		// We expect it to die without outputting anything if item-type is invalid.

Conversation

pbearne commented May 20, 2026

Uh oh!

github-actions Bot commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

github-actions Bot commented May 20, 2026

Test using WordPress Playground

Some things to be aware of

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

lancewillett left a comment

Choose a reason for hiding this comment

Uh oh!

lancewillett commented Oct 31, 2026

Uh oh!

lancewillett commented Oct 31, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 20, 2026 •

edited

Loading