Repository navigation
[Fuzzer] Update BINARYEN_CORES comment - #9316
Merged
Merged
Conversation
Explain that we are limiting the number of cores because the overhead from thread pool initialization and synchronization can be high when running on small modules.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds an explanatory comment in scripts/fuzz_opt.py regarding the overhead of thread pool setup and synchronization on multi-core machines. The review feedback correctly identifies spelling typos ('synchonization' and 'funtion-parallel') in the new comment and suggests the appropriate corrections.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
tlively
enabled auto-merge (squash)
October 27, 2026 23:58
kripken
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explain that we are limiting the number of cores because the overhead from thread pool initialization and synchronization can be high when running on small modules.