Repository navigation
Conversation
UvuvDev
force-pushed
the
mcp_user_tool_groups
branch
2 times, most recently
from
October 30, 2026 05:58
0b79428 to
13e05e2
Compare
bdash
requested changes
Oct 30, 2026
bdash
left a comment
bdash
left a comment
Contributor
There was a problem hiding this comment.
Rust support seems to have been missed.
|
|
||
|
|
||
| def register_group(name: str, title: str, description: str, *, default_enabled: bool = True) -> None: | ||
| """Register an MCP tool group and its user exposure setting.""" |
Contributor
There was a problem hiding this comment.
"user exposure setting" is strange phrasing.
Member
Author
There was a problem hiding this comment.
I decided to go with "Register an MCP tool group and its call permissions." Let me know if you have a different opinion on that
UvuvDev
force-pushed
the
mcp_user_tool_groups
branch
from
November 3, 2026 09:28
13e05e2 to
2a0695d
Compare
UvuvDev
force-pushed
the
mcp_user_tool_groups
branch
from
November 3, 2026 10:41
2a0695d to
2dbba9b
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add registered MCP tool group objects and tool membership to the C, C++, Python, and Rust APIs. Groups provide a name, title, description, default state, and queries for their current user setting. Tools retain their group object; registrations without a group use
other.Add a group handle to
BNMcpToolDefinitionand bump the core ABI to 193. C++/Python/Rust group registration defaults to enabled; C callers setBNMcpToolGroupDefinition.enabledByDefaultexplicitly. Update the existing MCP documentation to describe per-call binary handles and user-controlled groups.The two commits separate the API implementation and documentation from Rust group tests. The implementation commit also corrects an existing Rust test's stale binary error code.
Validation: 14 Rust tests and 24 Python tests passed against the companion core, along with all 86 native MCP tests. No debugger changes or dependencies are included.
Companion core implementation: https://github.com/Vector35/binaryninja/pull/2187.