Repository navigation
feat: add clientSideNoiseCancellationEnabled option to start() and reconnect() - #195
Open
murat-solidroad wants to merge 4 commits into
Open
murat-solidroad wants to merge 4 commits into
murat-solidroad wants to merge 4 commits into
Conversation
…apiAI#194) Default true, so current callers still get Krisp. reconnect() reuses the value from the last start() unless told otherwise. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
murat-solidroad
changed the title
With it off, start() and reconnect() no longer report an audio-processing-setup stage that never ran. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194.
start()andreconnect()always turn on Daily's Krisp noise cancellation. This adds an option to skip it.StartCallOptions.clientSideNoiseCancellationEnabled?: boolean, next tomicrophonePreflightEnabled. TheclientSideprefix keeps it apart from the assistant's server-sidebackgroundSpeechDenoisingPlan, which it does not change. Defaults totrue, so current callers see no change.reconnect(webCall, options?)takes the same option. Without it,reconnect()reuses the value from the laststart(), ortrueifstart()never ran on this instance.false, the SDK does not callupdateInputSettings. Daily's default processor isnone, so Krisp never loads and the microphone track is never swapped. The local audio level observer then starts at once, with no track swap to race (Serialize local audio level observer startup with noise cancellation setup #181).Tests
Six new cases in
__tests__/vapi.test.ts: the default, turning it off instart(),reconnect()keeping thestart()value,reconnect()overriding it,reconnect()with no priorstart(), and turning it off inreconnect().npx jestpasses 79/79 andtsc --noEmitis clean.🤖 Generated with Claude Code