Repository navigation
STUN: stop spamming if a keepalive request cant be sent - #463
Open
Ibn-Butt-Toota wants to merge 1 commit into
Open
Ibn-Butt-Toota wants to merge 1 commit into
Ibn-Butt-Toota wants to merge 1 commit into
Conversation
If a keepalive request fails due to a packet not being able to be sent at all (like if someone's only connection went away due to turning on airplane mode or the interface goes down) then STUN's keepalive would send a request, have it fail, then enqueue another request, which would immediately fail, etc., causing a core to get pinned, which also happens to block anything scheduled, including the connection's timeout. The core is pinned until either: 1) the connection is closed by whatever application is running it or 2) the original address returns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a keepalive request fails due to a packet not being able to be sent at all (like if someone's only connection went away due to turning on airplane mode or the interface goes down) then STUN's keepalive would send a request, have it fail, then enqueue another request, which would immediately fail, etc., causing a core to get pinned, which also happens to block anything scheduled, including the connection's timeout.
The core is pinned until either: 1) the connection is closed by whatever application is running it or 2) the original address returns.