Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The min-deps job (xarray 2024.10.0) fails four vector calculus tests from #1823, seen in https://github.com/UXARRAY/uxarray/actions/runs/41134745088. Before xarray 2025.11.0, apply_ufunc and binary ops drop attrs by default, so gradient/curl/divergence/scalardotgradient lose the input's non-value-describing attrs. Setting keep_attrs in apply_ufunc alone does not fix it, since the arithmetic steps drop attrs too, so this raises the floor instead; with xarray 2025.11.0 plus the other oldest allowed dependencies, test_vector_calculus.py passes (43 passed).