Skip to content

fix: recover locations from map home links - #217

Open
SamarthaB10 wants to merge 1 commit into
developfrom
issue-213-implementation
Open

SamarthaB10 wants to merge 1 commit into
developfrom
issue-213-implementation

Conversation

@SamarthaB10

@SamarthaB10 SamarthaB10 commented Nov 3, 2026 •

Copy link
Copy Markdown

Problem

CourseBook can show a classroom while its link points to the main campus map. The parser skips the classroom in that case. Fixes #213.

Fix

When the link points to the main map, read building and room from matching location text. Leave the map link empty. Keep the existing handling for other links.

Verification

  • Parsed the issue's CS 6313.001 sample: CSC, 3.205, and an empty map link.
  • go test ./parser and go vet ./... passed.

AI Disclosure

Samartha used Codex to understand the cause of hte parsing issue and then implement the fix

@SamarthaB10
SamarthaB10 requested review from a team as code owners November 3, 2026 18:23

@KBui4 KBui4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for locations in CSC, but it seems like there are other cases where we get empty locations for in-person sections. I found them out while parsing CourseBook with your changes. I know I didn't mention this in the issue, but could you fix them as well?

The other issue is that any section in JSOM I, JSOM II, or JSOM III do not get parsed properly because even with a valid locator link, when the text is split, there are 3 parts and not 2.

Scraped data:
buan4351.504.27s.html
opre3333.002.27s.html

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix empty locations for sections in the new Comet Student Center

2 participants