Skip to content

Fix recursion depth failure in string transformation reconstruction #15680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hulei22103-gif wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix recursion depth failure in string transformation reconstruction #15680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions strings/min_cost_string_conversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,20 @@ def assemble_transformation(ops: list[list[str]], i: int, j: int) -> list[str]:
>>> assemble_transformation(ops2, x2, y2)
['C1', 'I2', 'R23']
"""
if i == 0 and j == 0:
return []
elif ops[i][j][0] in {"C", "R"}:
seq = assemble_transformation(ops, i - 1, j - 1)
seq.append(ops[i][j])
return seq
elif ops[i][j][0] == "D":
seq = assemble_transformation(ops, i - 1, j)
seq.append(ops[i][j])
return seq
else:
seq = assemble_transformation(ops, i, j - 1)
seq.append(ops[i][j])
return seq
sequence = []
# Trace backwards without consuming one Python stack frame per operation.
while i != 0 or j != 0:
operation = ops[i][j]
sequence.append(operation)
if operation[0] in {"C", "R"}:
i -= 1
j -= 1
elif operation[0] == "D":
i -= 1
else:
j -= 1
sequence.reverse()
return sequence


if __name__ == "__main__":
Expand Down
Loading