Repository navigation
fix(searches): add null safety and Comparable consistency to JumpSearch - #7653
DenizAltunkapan merged 2 commits into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Hi @alxkm, opened this PR to add null safety guards (returning -1 on null/empty inputs) and ensure Comparable contract consistency (\key.compareTo(array[i]) == 0) in \JumpSearch, matching the conventions in other search algorithms in this package. Whenever convenient, please take a look! Thanks! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7653 +/- ##
============================================
- Coverage 82.22% 82.19% -0.03%
Complexity 8391 8391
============================================
Files 843 843
Lines 26125 26127 +2
Branches 5096 5096
============================================
- Hits 21480 21476 -4
- Misses 3857 3858 +1
- Partials 788 793 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@hardikkaurani thanks! |
Description
This pull request improves \JumpSearch:
ull\ array, empty array, and
ull\ key returning -1\ instead of throwing \NullPointerException.
CC: @alxkm for review