Repository navigation
Conversation
J2TeamNNL
marked this pull request as ready for review
October 27, 2026 02:51
…KingbaseES with PostgreSQL
…quoted routine bodies in Oracle mode
datlechin
enabled auto-merge (squash)
October 27, 2026 11:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kingbase://andkingbase8://URLs, libpq through the PostgreSQL plugin's sources.database_modeinside the bounded connect. PostgreSQL and Oracle modes connect. MySQL and SQL Server modes are refused. A server without the setting reads as PostgreSQL mode.AS '...',AS $$...$$) ends at its;. A PL/SQL body stays whole.sys_admin functions like theirpg_twins:sys_read_file,sys_ls_dir,sys_terminate_backendand the rest.''or NULL concatenation. In Oracle mode it now keeps column defaults, identity and generated flags, generation expressions and index spellings. COLLATE is evaluated once per column.LENGTHon Oracle and KingbaseES, where''reads as NULL.bytealiterals.SqlDialectswaps are reverted, and the Swift 6.2 compile changes in unrelated files are dropped.Test plan
apple/scripts/probes/check-kingbasees.shagainst KingbaseES V9R1C10: 25/25 in pg mode and in oracle mode. The old catalog SQL fails 4 of the new checks in oracle mode.sys_gate cases, curated-list rows, empty filters.MacOnlyImportRowTestspass.AllPluginsbuilds and all 43 plugins load. TableProCore grammar, vocabulary, query and PluginKit tests pass.PostgreSQLIndexReplayTests.suffixAndCut,PostgreSQLColumnQueryTests(generation expression frompg_attrdef),PostgreSQLCatalogSQLPinTests.columnsWithMaterializedViews,PostgreSQLColumnDDLSequenceCollationTests.collateClauseWrapsTheSameCollation.Needs the maintainer
Fixes #2283