Repository navigation
feat(formatter): read each engine's grammar, add layout options and Vim tab commands - #3854
Merged
Merged
Conversation
…ons and Vim tab commands
…d multi-word types intact
…d keep implicit aliases
datlechin
enabled auto-merge (squash)
October 27, 2026 07:36
…PostgreSQL keywords
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[names],GOlines andPart#-style names; PostgreSQL$$bodies,E''and strings continued on the next line; MySQL#comments,DELIMITERandEND$$; Oracleq''and/; multi-character operators such as@>,+=,==and**;0xandN''literals.ORDER BY,WITHIN GROUP,OUTER APPLY, calls inCREATE VIEW, columns named like keywords, nested CASE, subquery indent and HAVING.GO,DELIMITERor/line. A script with manyGObatches formats in linear time.SQLDialectDescriptor.typeNamesAreCaseInsensitive, set in every curated and plugin dialect whose engine folds type names (not ClickHouse). It is additive PluginKit API, so the kit is 41: v0.83.0 and v0.84.0-beta.1 shipped kit 40 from release branches.check-pluginkit-abi.shcompares against the tag that shipped the highest kit, not the newest one HEAD reaches.plugin-system.mdsays the same..sql-formatter.jsonuses npm sql-formatter's keys for shared settings, and TablePro never writes a key that tool rejects. A file exported by 0.83 has to be exported again.gt,gT,{N}gt,:tabn,:tabpand:tabNswitch tabs. A count past the last tab selects the last tab."_register writes nothing.feat/3850-routine-debugger.SQLFormatterRulesTests: the new file keys.SQLFormatterServiceTests.windowFrameInline: now checks exact output; it used to pass on broken output.SQLLexicalFeatureMappingTests: the app-curated T-SQL name fact.SQLFormatterServiceTests.createTableColumnClauses:timestamp with time zoneis one type now, so it keeps its typed spelling.Test plan
"_register.swift teston TableProSQLGrammar and TableProEditor, all plugins,verify.sh abi(changed against v0.84.0-beta.1, kit 41, minimum 19).Screenshots
Refs #3850