Repository navigation
Remove the saved Sublime Text session before each Docker run - #309
Merged
Merged
Conversation
Sublime Text is killed after the tests, so the cache volume keeps the session that it last saved, with the views that tests had open at that time. The next run restored those views before the tests started, which made tests that expect no open views fail locally, while they passed on CI, where every run starts without a session.
Member
|
Maybe ST should run with hot_exit: false |
Member
Author
|
Haven't tried but that would possibly mean that: |
Member
|
Not sure about the origin, but it feels a bit hard to just kill the app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sublime Text is killed after the tests, so the Docker cache volume keeps the session that it last saved, with the views that tests had open at that time. The next run restores those views before the tests start. Tests that expect no open views then fail locally, while they pass on CI, where every run starts without a session.
For example, after a full run of the LSP tests,
tests/test_documents.pyfailed on its own run: the restoredtestfile.txtview made LSP start sessions for the test configs before the test expected any.The entrypoint now removes
Local/*.sublime_sessionbefore each run. With that, a full LSP run followed bytest_documents.pyon its own passes.