Skip to content

Remove broken link - #413

Merged
garloff merged 1 commit into
mainfrom
gerbsen-patch-1
Nov 9, 2026
Merged

garloff merged 1 commit into
mainfrom
gerbsen-patch-1

Conversation

@gerbsen

@gerbsen gerbsen commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

The link does not exist any more. Where did it lead before?

Signed-off-by: gerbsen <1186245+gerbsen@users.noreply.github.com>
@gerbsen
gerbsen requested a review from a team as a code owner November 9, 2026 15:04
@garloff

garloff commented Nov 9, 2026

Copy link
Copy Markdown
Member

I broke it in #405. And I wonder why I failed to notice the breakage which CI should have flagged.

Removing the link is good. The sidebar navigation has the information at the reader's fingertips when reading this doc.

@garloff garloff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could have the current PB always carry the neutral filename, so the link works. This results in renaming the file whenever we enter a new PB year, breaking deep links at that point. I prefer not having to rename.
So we just do without the link, the information is close enough and can be found easily.

@garloff
garloff merged commit 17780ad into main Nov 9, 2026
8 checks passed
@garloff
garloff deleted the gerbsen-patch-1 branch November 9, 2026 16:52
@gerbsen

gerbsen commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

@garloff I remember briefly that in the other issue with #392 I also found broken links which the pipeline didn't catch. Did you find the reason why this went unnoticed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants