Repository navigation
🌱 feat(builder): Use builder 1.1.35 - #349
Merged
Merged
Conversation
Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
jschoone
changed the title
The builder image 1.1.35 contains golangci-lint v2.10.1 (was v2.2.1), which reports 15 findings in the existing code and fails the lint job. - noctx: run helm with exec.CommandContext and pass the context through (helmTemplate, helmTemplateClusterAddon, helmTemplateNewClusterStack, templateClusterClassHelmChart). helm is now stopped when the reconcile context is cancelled. Use a net.Dialer with DialContext in WaitForWebhooks. - prealloc: build the helm argument lists in one literal. - revive enforce-switch-style: add default clauses to the switches in clusteraddon_controller.go, clusterstackrelease/util.go, pkg/kube/helpers.go and pkg/version/version.go. They do nothing, the behaviour is unchanged. - revive var-naming: the package name version conflicts with the standard library package go/version. pkg/version is public, so it is not renamed; the finding is excluded for pkg/version in .golangci.yaml. - gosec G703 in unTarContent: header.Name of a tar entry was joined to the destination without a check, so an entry with ../ could be written outside of it. Reject entries for which filepath.IsLocal is false. gosec does not recognize this check, so the remaining report is suppressed with a reason. G204 for the fixed command helm is suppressed with a reason as well (it showed up once noctx was fixed). - gosec G704: the URL in handleRedirect is the download location the GitHub API returned for the release asset; suppressed with a reason. - gosec G602 in the test: replace equalStringSlices by slices.Equal. Add TestUnTarContent. It passes with the check and fails without it. Checked with the published image ghcr.io/sovereigncloudstack/cso-builder:1.1.35 on a temporary OpenStack VM: make lint-golang-ci reports 0 issues; go vet, the unit tests of pkg, extension and internal/clusterstackrelease and the controller suite (envtest with Kubernetes 1.29.3 and 1.35.0) pass. Not run: the integration tests that need kind. Signed-off-by: Jan Schoone <6106846+jschoone@users.noreply.github.com>
schmidax
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New builder resulted from #348