Repository navigation
test(construction): pin what each scalar construction heuristic assigns - #204
Merged
Merged
Conversation
No test solved with first_fit_decreasing, weakest_fit, weakest_fit_decreasing, strongest_fit, strongest_fit_decreasing, allocate_entity_from_queue or allocate_to_value_from_queue and checked the result, so mapping one heuristic to another's entity order, value order or forager passed every test. One solve per scalar construction heuristic now asserts its assignment on a domain where every heuristic's documented order and forager gives a different result, plus two solves whose order keys change as construction assigns: one pins the per-step entity re-sort (live refresh), the other the per-placement value order. Removing each heuristic's entity order, value order, forager choice or live refresh fails at least one of them. Closes #203.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #203. Base
main@ea589bb0, one test-only commitff11cd47.Local: fmt, clippy -D warnings, doc-names file-length facade-reachability public-api deps, workspace all-feature tests: EXIT 0, 1513 passed, 0 failed, 61 result lines.
Mutation checks in
runtime_slots/placement.rs, each failing at least one test: canonical entity order for first_fit_decreasing / weakest_fit_decreasing / strongest_fit_decreasing / allocate_entity_from_queue; canonical value order for allocate_to_value_from_queue; weakest and strongest foragers swapped; first fit for cheapest_insertion; live refresh off.