Repository navigation
feat: accept SolverConfigOverride (with_override, solve_with_override) - #198
Merged
Merged
Conversation
…erride `SolverConfigOverride` was exported and documented as a runtime override but nothing accepted it. `SolverConfig::with_override` applies one: each field the override sets replaces the configured one, so a set `termination` replaces the solver-level termination and leaves phase terminations alone.
A retained solve always ran with its solution's own configuration, so there was no way to change a job's termination at submission. `SolverManager::solve_with_override` stores the override in the job record, and `SolverRuntime::apply_config_override` applies it at the run entry point every configured solve reaches, so generated, weighted and bridge solves all honour it. Jobs submitted without one, and detached solves, run with their configuration unchanged. Closes #197.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #197. Base
main@62388fea, two commits:a73be457feat(config): apply a SolverConfigOverride with SolverConfig::with_override958303a4feat(manager): run a retained job under a SolverConfigOverrideSlice 1 alone: config clippy, rustdoc, doc-names and tests (32 + 3 passed). Gate on
958303a4(fmt, clippy, doc-names file-length facade-reachability public-api deps, rustdoc, examples, workspace all-feature tests, doctests): EXIT 0, 1541 passed, 0 failed, 67 result lines. Mutation check: without theapply_config_overridecall at the run entry point,tests/config_override.rsfails (the job runs to its configured 1000 steps instead of the override's 10).