Repository navigation
fix(construction)!: reject construction keys that cannot apply - #196
Merged
Merged
Conversation
…istics `value_candidate_limit`, `group_candidate_limit` and `construction_obligation` shape scalar candidate generation, and list heuristics read none of them, so setting one on `list_round_robin`, `list_cheapest_insertion`, `list_regret_insertion`, `list_clarke_wright` or `list_k_opt` did nothing. Each is now a configuration error naming its key path; the default `construction_obligation` stays accepted. BREAKING CHANGE: a list construction heuristic with `value_candidate_limit`, `group_candidate_limit` or a non-default `construction_obligation` is a configuration error.
`group_candidate_limit` caps grouped scalar candidates, which exist only with `group_name`; without one the cap did nothing. It is now a configuration error naming its key path. Closes #193. BREAKING CHANGE: `group_candidate_limit` without `group_name` is a configuration error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #193. Base
main@5f54b049, two commits:91362a48reject scalar-only keys on list construction heuristics62388fearequire group_name for group_candidate_limitSlice 1 alone: fmt, clippy -D warnings, doc-names, config rustdoc, compiler and config tests: 123 passed, 0 failed. Gate on
62388fea(fmt, clippy, doc-names file-length facade-reachability public-api deps, rustdoc, examples, workspace all-feature tests, doctests): EXIT 0, 1539 passed, 0 failed, 66 result lines. Mutation check: removing either rule fails its test (list_construction_rejects_scalar_only_keys,group_candidate_limit_needs_a_group_name). No fixture, example or doc sets these keys where they are now rejected.