Repository navigation
move pane menu item prepration to solid-ui - #918
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the pane-menu preparation change.
No open issues 🎉
What changed in this PR
Adds reusable pane-menu preparation to solid-ui’s file-explorer helpers so callers can turn pane definitions into resource-menu actions.
Changes:
- Adds
preparePaneMenuItems, preserving pane order, filtering unlabeled panes, and resolving icons with optional host overrides. - Exports the helper and its types through the file-explorer entry point.
- Adds tests for menu preparation and supplied action-event forwarding.
| File | Description |
|---|---|
test/unit/file-explorer/pane-menu-items.test.ts |
Tests ordering, label filtering, icon resolution, overrides, and action forwarding. |
src/lib/file-explorer/pane-menu-items.ts |
Defines menu types and implements asynchronous pane-menu preparation. |
src/lib/file-explorer/index.ts |
Exports the new helper and types. |
src/components/resource-actions-menu/ResourceActionsMenu.test.ts |
Tests rendering supplied actions and forwarding selection events. |
Review effort: Balanced
SharonStrats
force-pushed
the
feat/folder-refactor
branch
from
November 2, 2026 11:19
6b66c20 to
ff2d1a8
Compare
…istry@5.0.2-2) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up code when refactoring folder-pane for additional 3 dot menu on storage-header.