Repository navigation
fix dokeili loading - #793
Merged
Merged
Conversation
Prompt: There is now an issue with dokeili menu stuck in loading please investigate and fix Co-authored-by: Claude Opus 5.5 <claude-5.5-opus@openai.com>
…@5.0.2-5 pane-registry@5.0.2-2 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The fetch wrapper calls includes on non-string bodies such as ArrayBuffer, causing valid PUT saves to throw before reaching the server and leaving the bridge promise pending.
1 open issue
What changed in this PR
This PR addresses Dokieli preview loading issues in the human-readable pane while preserving iframe isolation and mediated requests.
Changes:
- Adds in-memory storage fallbacks, viewer-profile reads, and explicit responses to denied requests.
- Removes injected preview bridge scripts when loading and saving documents, with additional regression tests.
- Delegates file-explorer pane menu preparation to the shared UI helper.
| File | Description |
|---|---|
test/unit/humanReadablePane.test.ts |
Tests request permissions, bridge cleanup, storage fallbacks, and denied-request responses. |
src/outline/fileExplorerHelpers.ts |
Uses the shared pane menu helper while retaining icon overrides. |
src/humanReadablePane.ts |
Updates preview storage, request handling, and bridge-script cleanup. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…@5.0.2-6 pane-registry@5.0.2-2 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For some reason dokeili starting having loading issues where the menu would not load found this when running e2e for folder pane work.
Also some cleanup, use the new prepare pane function