Skip to content

fix dokeili loading - #793

Merged
SharonStrats merged 4 commits into
stagingfrom
fix/dokeili
Nov 2, 2026
Merged

SharonStrats merged 4 commits into
stagingfrom
fix/dokeili

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

For some reason dokeili starting having loading issues where the menu would not load found this when running e2e for folder pane work.

Also some cleanup, use the new prepare pane function

Prompt: There is now an issue with dokeili menu stuck in loading please investigate and fix

Co-authored-by: Claude Opus 5.5 <claude-5.5-opus@openai.com>
…@5.0.2-5 pane-registry@5.0.2-2 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
@SharonStrats SharonStrats linked an issue Nov 2, 2026 that may be closed by this pull request

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The fetch wrapper calls includes on non-string bodies such as ArrayBuffer, causing valid PUT saves to throw before reaching the server and leaving the bridge promise pending.

1 open issue
What changed in this PR

This PR addresses Dokieli preview loading issues in the human-readable pane while preserving iframe isolation and mediated requests.

Changes:

  • Adds in-memory storage fallbacks, viewer-profile reads, and explicit responses to denied requests.
  • Removes injected preview bridge scripts when loading and saving documents, with additional regression tests.
  • Delegates file-explorer pane menu preparation to the shared UI helper.
File Description
test/​unit/​humanReadablePane.test.ts Tests request permissions, bridge cleanup, storage fallbacks, and denied-request responses.
src/​outline/​fileExplorerHelpers.ts Uses the shared pane menu helper while retaining icon overrides.
src/​humanReadablePane.ts Updates preview storage, request handling, and bridge-script cleanup.

Review effort: Balanced

Comment thread src/humanReadablePane.ts Resolved
SharonStrats and others added 2 commits November 2, 2026 22:24
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…@5.0.2-6 pane-registry@5.0.2-2 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
@SharonStrats
SharonStrats merged commit 4d73a71 into staging Nov 2, 2026
8 checks passed
@SharonStrats
SharonStrats deleted the fix/dokeili branch November 2, 2026 12:25
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Dokeili has a menu loading issue

2 participants