Repository navigation
Reject retired API credentials before use - #113
Open
John-David Dalton (jdalton) wants to merge 1 commit into
Open
John-David Dalton (jdalton) wants to merge 1 commit into
John-David Dalton (jdalton) wants to merge 1 commit into
Conversation
John-David Dalton (jdalton)
force-pushed
the
jdalton/retired-credential-recovery
branch
2 times, most recently
from
October 13, 2026 12:52
450003c to
a59fb21
Compare
John-David Dalton (jdalton)
force-pushed
the
jdalton/retired-credential-recovery
branch
from
October 13, 2026 12:52
a59fb21 to
ebc9146
Compare
Joseph Werle (jwerle)
approved these changes
Oct 26, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject the retired shared API credential before the Python SDK stores or encodes it. The error tells users to configure a replacement; valid credentials keep their existing selection order and encoded bytes.
Implementation and validation
Checks SDK construction and Basic-auth username encoding, including explicit arguments and all four environment sources. Compares a SHA-256 fingerprint; source and errors contain no credential value.
Validation: 12 focused tests passed. New helper and test files passed Ruff. Tests use synthetic credentials and make no Socket API calls.
Links and PR checklist
Reject a retired shared API credential with instructions to configure a replacement.
Automated review notes