Skip to content

Run ci-ok on a GitHub-hosted runner #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mikola Lysenko (mikolalysenko) wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Run ci-ok on a GitHub-hosted runner #1747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e631e18
Run ci-ok on a GitHub-hosted runner
claude Oct 27, 2026
db0d137
Merge remote-tracking branch 'origin/main' into pr1747
claude Oct 27, 2026
800ff09
Keep a repo-variable switch for the ci-ok runner
claude Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2881,7 +2881,11 @@ jobs:
name: ci-ok # registered as a required check; do not rename
if: always()
needs: [clippy, node-addon, lint-ecosystems, release-readiness, test, test-release, coverage, docker-base, coverage-docker, coverage-merge, dispatch-tests, e2e-build, windows-compile-check, e2e-build-windows, e2e-build-macos, e2e, e2e-windows, e2e-extended, e2e-full, e2e-docker, yarn-classic-matrix, yarn-berry-e2e, yarn-berry-full, cargo-vex-matrix, cargo-vex-matrix-windows, cargo-vex-matrix-full, cargo-old-toolchains, hosted-e2e, e2e-macos, yarn-berry-e2e-macos, cargo-vex-matrix-macos]
runs-on: ${{ vars.DISABLE_DEPOT_RUNNERS == 'true' && 'ubuntu-latest' || 'depot-ubuntu-24.04-4' }}
# GitHub-hosted, not Depot: the check is one 2 s python3 call that runs
# alone at the end of every run, so a Depot host boot always lands on the
# merge's critical path (#1745). If hosted Linux backs up, set the repo
# variable CI_OK_RUNNER (e.g. depot-ubuntu-24.04-4); no merge needed.
runs-on: ${{ vars.CI_OK_RUNNER || 'ubuntu-latest' }}
timeout-minutes: 5
steps:
- name: Check every needed job
Expand Down
6 changes: 6 additions & 0 deletions scripts/tests/test_ci_scheduling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ def test_required_verdict_includes_every_job(self):
for job in JOBS:
ancestors(job) # All dependencies exist and the graph is acyclic.

def test_ci_ok_defaults_to_a_hosted_runner(self):
# A 2 s check that runs last must not pay a Depot host boot on the
# merge's critical path (#1745); the repo variable is the escape hatch.
runs_on = [line for line in JOBS["ci-ok"] if line.startswith(" runs-on:")]
self.assertEqual(runs_on, [" runs-on: ${{ vars.CI_OK_RUNNER || 'ubuntu-latest' }}"])

def test_expensive_jobs_cannot_start_after_a_failed_preflight(self):
cheap = {"clippy", "lint-ecosystems", "release-readiness", "dispatch-tests", "ci-ok"}
# windows-compile-check is the lean queue's only Windows job and sits
Expand Down
Loading