Skip to content

Nightly mode_migration_vlt red: vendor tests predate #1648 eject #1774

Closed

Description

[agent] Filed by the CI-lane fixer.

The nightly CI run on main (40639505834, head b787454) fails e2e-extended (mode_migration_vlt, *, --include-ignored vlt_pinned_matrix) on every vlt leg (vlt 0.0.0-32, 1.0.0-rc.14, 1.2.0 on Linux, plus the Windows/macOS legs):

thread 'vlt_pinned_matrix_migration_hosted_then_vendored' panicked at crates/socket-patch-cli/tests/mode_migration_vlt.rs:312:9:
vendor: exit 0
  ... "errorCode": "vendor_prebuilt_downloaded" ... "vendor_vlt_reinstall_required" ...
failures:
    vlt_pinned_matrix_migration_dry_run_parity
    vlt_pinned_matrix_migration_hosted_then_vendored

Root cause: #1648 made plain vendor with a hosted pin in scope an eject (dry run reports eject_planned, the wet run no longer emits vendor_takeover_reverted_redirect). It updated the PR-tier migration suites (mode_migration_bun.rs, _npm, _cargo, _pypi) but missed mode_migration_vlt.rs, whose tests are #[ignore] (real vlt) and run only in the nightly e2e-extended legs. The vendor runs themselves succeed; only the stale advisory assertions fail:

  • mode_migration_vlt.rs:310-313 (hosted_then_vendored, vendor driver) expects vendor_takeover_reverted_redirect.
  • mode_migration_vlt.rs:360-363 (dry_run_parity) expects vendor_would_revert_redirect from vendor --dry-run.
  • mode_migration_vlt.rs:385-388 (dry_run_parity) expects vendor_takeover_reverted_redirect from the wet vendor.

Fix (test-only): assert the eject contract the bun suite now asserts. Sibling of #1770 (same #1648 fallout in e2e_bun_lockb.rs).


Generated by Claude Code

Activity

  1. mikolalysenko commented on Oct 28, 2026

    @mikolalysenko
    CollaboratorAuthor

    [agent] Claiming this issue (shared root cause: #1648's eject contract not applied to nightly-only mode_migration_vlt tests). Branch: agent/fix-ci-vlt-migration-eject. Claim-ID: 2026-10-28T07:51:33Z-8ccf02


    Generated by Claude Code

  2. added a commit that references this issue on Oct 28, 2026
    a7a9fe8
  3. mikolalysenko commented on Oct 28, 2026

    @mikolalysenko
    CollaboratorAuthor

    [agent] Fix PR: #1775 (test-only; red→green on vlt 1.2.0, 0.0.0-32, 1.0.0-rc.14 locally).


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions