Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fires
ServerChunkEvents.CHUNK_LOAD,CHUNK_GENERATEandCHUNK_UNLOADfrom NeoForge'sChunkEvent.Load/Unload(server levels only) instead of the vanilla injections inChunkStatusTasksandChunkMap. Mods that replace vanilla's chunk system and post NeoForge's events themselves, such as Moonrise, then get the Fabric events too. See #302.ChunkEvent.Loadis posted at the end of the sameChunkStatusTasks.fulllambda the old injection targeted, andisNewChunk()uses the same!(protoChunk instanceof ImposterProtoChunk)check asgenerated.ChunkMapMixinis removed.CHUNK_UNLOADnow fires after the chunk is saved, as NeoForge'sChunkEvent.Unloaddoes, rather than before.FULL_CHUNK_STATUS_CHANGEtransitions are still fired fromChunkStatusTasksMixin; NeoForge has no equivalent event.Tested on a 26.1.2 dedicated server by counting events for one chunk through generate, unload, reload and server stop:
LoadedChunksCachetracks the chunk correctly in both "after" runs. Full status changes with Moonrise are left for Moonrise to handle.