Repository navigation
Fix raw ENOENT when a web pixel bundle is missing with --no-build - #9049
Open
isaacroldan wants to merge 1 commit into
Open
isaacroldan wants to merge 1 commit into
isaacroldan wants to merge 1 commit into
Conversation
With `app deploy --no-build`, buildUIExtension runs the extension's buildValidation before anything checks that the bundle exists. The web pixel validation reads the bundle size, so a missing bundle failed with a raw ENOENT instead of the missing-output AbortError of the bundle_ui step. Check for the output file before buildValidation when skipBuild is set, and throw the same error. Move that error into a MissingBuildOutputError class so both places print the same message. Co-authored-by: isaac.roldan <isaac.roldan@shopify.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
app deploy --no-buildwith a web pixel extension that was never built fails with a raw filesystem error:buildUIExtensionruns the extension'sbuildValidationbefore thebundle_uistep checks that the build output exists. The web pixel validation reads the bundle size, so it fails first, and the clear missing-output error never shows.WHAT is this pull request doing?
When
skipBuildis set and the bundle file does not exist,buildUIExtensionnow throws the sameAbortErroras thebundle_uistep, beforebuildValidationruns. The error moves into aMissingBuildOutputErrorclass, so both places print the same message.Output after the change:
How to manually test your changes?
distdirectory.shopify app deploy --no-build.ENOENT: no such file or directory, stat …. After: it fails withCouldn't find the build output at …and the--no-buildhint.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add