Repository navigation
Treat DO_NOT_TRACK=1 as an analytics opt-out - #9045
Open
hasandenizuk wants to merge 1 commit into
Open
hasandenizuk wants to merge 1 commit into
hasandenizuk wants to merge 1 commit into
Conversation
Author
|
I have signed the CLA! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
DO_NOT_TRACK=1is a common cross-tool way to opt out of telemetry (https://consoledonottrack.com/). Developers who set it once for all their tools still have Shopify CLI usage analytics sent, because the CLI only checksSHOPIFY_CLI_NO_ANALYTICSandOPT_OUT_INSTRUMENTATION.WHAT is this pull request doing?
Adds
DO_NOT_TRACKto the environment variable constants incli-kitand makesanalyticsDisabled()return true when it is truthy, the same wayOPT_OUT_INSTRUMENTATIONwas added in #7503. The existing opt-outs behave as before. Includes a unit test and a patch changeset.How to manually test your changes?
Run
DO_NOT_TRACK=1 shopify version --verbose. Before: the output ends with "Analytics event sent". After: it shows "Skipping command analytics".Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add