Skip to content

#57 stop tracking .claude/settings.local.json and add the shared attribution settings - #58

Merged
docktermj merged 1 commit into
mainfrom
claude-settings-untrack
Nov 12, 2026
Merged

docktermj merged 1 commit into
mainfrom
claude-settings-untrack

Conversation

@kernelsam

@kernelsam kernelsam commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

stop tracking .claude/settings.local.json and add the shared attribution settings

Refs #57


Resolves #57

@kernelsam
kernelsam requested a review from a team as a code owner November 12, 2026 19:34
@kernelsam kernelsam self-assigned this Nov 12, 2026
@github-actions

Copy link
Copy Markdown

🤖 Claude Code Review

Code Review

This PR stops tracking .claude/settings.local.json, adds a shared .claude/settings.json with attribution settings, and gitignores the local file. It is a config-only change.

Code Quality

  • ✅ Style conventions: .claude/settings.json is valid JSON with consistent 2-space indentation. The .gitignore entry follows the existing pattern.
  • ✅ No commented-out code.
  • ✅ Meaningful names: The keys are the Claude Code settings schema's own.
  • ✅ DRY: There is no duplication.
  • ✅ Defects: I found no bugs.
    • ⚠️ Minor: includeCoAuthoredBy is deprecated in favor of attribution. attribution.commit: "" already suppresses the co-author trailer, so includeCoAuthoredBy: false is redundant. It is harmless and could stay for older Claude Code versions.
    • ⚠️ Minor: .gitignore:59 adds .claude/settings.local.json after the file was already tracked. That is fine here because the same PR deletes it from the index. Developers who pull this change may find their local copy removed once, and they will need to recreate it if they rely on it.
  • ✅ .claude/CLAUDE.md: The PR doesn't add or change one. The shared settings.json has no environment-specific values such as paths, usernames, or machine settings, so it works for any developer.

Testing

  • ✅ Not applicable: There is no executable code, so no unit tests, integration tests, edge-case tests, or coverage apply.

Documentation

  • ✅ README and API docs: No update needed.
  • ✅ Inline comments: None needed. JSON doesn't support comments, and the settings are self-explanatory.
  • ⚠️ CHANGELOG.md: The diff doesn't touch it. This is tooling and config only, so an entry is optional. If the project logs CI and tooling changes, add a line.
  • ✅ Markdown: No Markdown files changed.

Security

  • ✅ No hardcoded credentials.
  • ✅ Input validation: Not applicable.
  • ✅ Error handling: Not applicable.
  • ✅ No sensitive data in logs.
  • ✅ No license files: No .lic files, and no strings starting with AQAAAD.

Summary

The PR is clean and ready to merge. The only suggestions are optional: drop the deprecated includeCoAuthoredBy, and add a CHANGELOG line if the project tracks tooling changes.

Automated code review analyzing defects and coding standards

@docktermj
docktermj merged commit fa19eff into main Nov 12, 2026
12 checks passed
@docktermj
docktermj deleted the claude-settings-untrack branch November 12, 2026 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop tracking .claude/settings.local.json

2 participants