Skip to content

#27 stop tracking .claude/settings.local.json and add the shared attribution settings - #28

Merged
docktermj merged 1 commit into
mainfrom
claude-settings-untrack
Nov 13, 2026
Merged

docktermj merged 1 commit into
mainfrom
claude-settings-untrack

Conversation

@kernelsam

@kernelsam kernelsam commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

stop tracking .claude/settings.local.json and add the shared attribution settings

Refs #27


Resolves #27

@kernelsam
kernelsam requested a review from a team as a code owner November 13, 2026 03:14
@kernelsam kernelsam self-assigned this Nov 13, 2026
@github-actions

Copy link
Copy Markdown

🤖 Claude Code Review

Code Review: PR #27, stop tracking settings.local.json and add shared attribution settings

Summary: This PR moves the shared Claude Code attribution config into a tracked .claude/settings.json. It deletes the tracked .claude/settings.local.json and adds that file to .gitignore. I found no defects. I only read the diff and didn't open the repo to check for a CHANGELOG or .claude/CLAUDE.md.

Code Quality

  • ✅ Style conventions: The JSON is valid, uses 2-space indentation and has a trailing newline. The .gitignore entry matches the existing format.
  • ✅ No commented-out code.
  • ✅ Meaningful names: The keys come from the Claude Code settings schema.
  • ✅ DRY: The settings now live in one shared file instead of a per-developer local file.
  • ✅ Defects:
    • Ignoring .claude/settings.local.json is correct, because that file is meant to be per-developer. The deletion drops it from the index. Developers who already have it checked out may find it removed locally after pulling, which is harmless.
    • ⚠️ Minor, .claude/settings.json:7: includeCoAuthoredBy is deprecated in favor of the attribution object. Setting attribution.commit to "" already removes the co-author trailer, so the old key is redundant. It's harmless and keeps older Claude Code versions working, so keep it if you need that compatibility. Otherwise drop it.
  • ✅ .claude/CLAUDE.md: The PR doesn't touch it. The new settings.json has nothing specific to a local environment, such as paths or user names.

Testing

  • ✅ Not applicable: This is a configuration-only change with no new functions or endpoints, so no unit or integration tests or coverage apply.

Documentation

  • ✅ README and API docs: No update is needed.
  • ⚠️ CHANGELOG.md: The PR doesn't update it. If the repo keeps a CHANGELOG for tooling or config changes, add a line. If it only tracks releases, this is fine.
  • ✅ Markdown/prettier: The PR changes no Markdown files.

Security

  • ✅ No hardcoded credentials.
  • ✅ Input validation: Not applicable.
  • ✅ Error handling: Not applicable.
  • ✅ No sensitive data in logs.
  • ✅ No license files: There are no .lic files and no strings starting with AQAAAD.

Verdict

✅ Approve. The only optional follow-ups are removing the deprecated includeCoAuthoredBy key and adding a CHANGELOG entry if the repo expects one.

Automated code review analyzing defects and coding standards

@docktermj
docktermj merged commit 2cb06d5 into main Nov 13, 2026
12 checks passed
@docktermj
docktermj deleted the claude-settings-untrack branch November 13, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop tracking .claude/settings.local.json

2 participants