Repository navigation
zeroize: fix ignored zeroize_c_string test - #1587
Open
bardiharborow wants to merge 3 commits into
Open
bardiharborow wants to merge 3 commits into
bardiharborow wants to merge 3 commits into
Conversation
`ProxyAllocator::dealloc` asserted that the registered allocation was zeroized, but `GlobalAlloc` methods must not unwind, so a failure aborted the whole test binary with no diagnostic. Record the failure in a flag instead, and check it from the test thread in `assert_checked`, which also checks that the registered allocation was actually freed. Signed-off-by: Bardi Harborow <bardi@bardiharborow.com>
`REG_PTR` is a global, so tests which register an allocation with it must not run concurrently. Add a mutex for such tests to hold, in preparation for adding more of them. Signed-off-by: Bardi Harborow <bardi@bardiharborow.com>
The test read the CString's original buffer after `zeroize()`, but that buffer may already be freed by then, which is UB. Replace it with `cstring_zeroize_test` in `tests/alloc.rs`, which checks the original buffer with the proxy allocator when it is freed. Signed-off-by: Bardi Harborow <bardi@bardiharborow.com>
bardiharborow
force-pushed
the
zeroize-fix-cstring-test
branch
from
November 3, 2026 07:23
a06e6f9 to
ff4b5c6
Compare
bardiharborow
marked this pull request as ready for review
November 3, 2026 07:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test read the CString's original buffer after
zeroize(), but that buffer may already be freed by then, which is UB. Check the result directly instead, and check the original buffer with the proxy allocator intests/alloc.rs.Fixes #774