Repository navigation
Add signature max size restrictions - #767
Merged
Merged
Conversation
In addition to the checks used before computing a `BoxedUint` from the signature bytes, which is done after checking the modulus size, this adds some additional eager checks that the signature size falls within the range of the maximum modulus size. Also adds `new_with_max_size` escape hatch methods in case for whatever reason there is a need to construct larger signatures, however this doesn't apply to the standard `TryFrom` impls, serde, etc. Closes #350
tarcieri
force-pushed
the
add-signature-max-length-restrictions
branch
from
November 3, 2026 00:00
57b0be7 to
50ab7ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the checks used before computing a
BoxedUintfrom the signature bytes, which is done after checking the modulus size, this adds some additional eager checks that the signature size falls within the range of the maximum modulus size.Also adds
new_with_max_sizeescape hatch methods in case for whatever reason there is a need to construct larger signatures, however this doesn't apply to the standardTryFromimpls, serde, etc.Closes #350