Skip to content

tests: check ownership support before enumerating passwd entries - #1160

Closed
psumbera wants to merge 1 commit into
RsyncProject:masterfrom
psumbera:fix3
Closed

psumbera wants to merge 1 commit into
RsyncProject:masterfrom
psumbera:fix3

Conversation

@psumbera

@psumbera psumbera commented Nov 9, 2026

Copy link
Copy Markdown

The name-converter test enumerates passwd entries before checking whether it can change file ownership. Network name services can block that enumeration even for an unprivileged run that will skip this part of the test.

Check owners_supported() first and enumerate accounts only when the name-converter test can run. Preserve early-exec coverage, the existing skip condition and all privileged name-converter assertions.

The name-converter test enumerates passwd entries before checking
whether it can change file ownership. Network name services can block
that enumeration even for an unprivileged run that will skip this part
of the test.

Check owners_supported() first and enumerate accounts only when the
name-converter test can run. Preserve early-exec coverage, the existing
skip condition and all privileged name-converter assertions.
steadytao added a commit that referenced this pull request Nov 10, 2026
Adapt #1158, #1159 and #1160 to the reorganised testsuite.

Co-authored-by: Petr Sumbera <sumbera@volny.cz>
@steadytao

Copy link
Copy Markdown
Member

Folded * 3

@steadytao steadytao closed this Nov 10, 2026
steadytao added a commit that referenced this pull request Nov 11, 2026
Adapt #1158, #1159 and #1160 to the reorganised testsuite.

Co-authored-by: Petr Sumbera <sumbera@volny.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants