Repository navigation
Conversation
- Add foxglove_msgs/CompressedImage passthrough streaming - Add foxglove_msgs/CompressedVideo browser playback support - Forward encoded video frames without decode or re-encode - Add browser-side WebCodecs decoding - Handle Annex-B and AVCC H.264 payloads - Cache SPS/PPS and initialize H.264 decoding from keyframes - Add Foxglove streamer plugin registration and dependencies
- Add width and height query parameters to the Foxglove video viewer - Preserve aspect ratio when only one output dimension is specified - Add display_fps query parameter for client-side frame presentation limiting - Continue decoding full video while reducing canvas rendering work - Wait for a usable keyframe without aborting the stream - Retry initial stream startup until decoder configuration succeeds
- Pass subscriber factory maps through Foxglove streamer constructors - Update streamer factory create_streamer() signatures - Update get_available_topics() signatures for the new upstream API - Preserve direct typed subscriptions for Foxglove compressed image and video topics - Restore compatibility with the latest ros2 branch subscriber plugin changes
- Apply ament_uncrustify formatting to Foxglove image streamer - Apply ament_uncrustify formatting to Foxglove video streamer - Resolve industrial_ci source test failures
- Update formatting for Humble uncrustify compatibility - Add direct includes required by Rolling clang-tidy - Remove unused includes - Rename constexpr variables to match project naming rules - Suppress FFmpeg parser const-correctness warning where required
- Add direct subscriber interface includes - Add direct FFmpeg codec ID and decoder includes - Rename frame header size constant to match project naming rules - Resolve remaining include-cleaner warnings in Foxglove streamers
- Add direct libavcodec codec header include - Resolve clang-tidy warning for avcodec_find_decoder() - Keep Rolling CI compatible with strict include-cleaner checks
Author
|
It appears the remaining pipeline failures at this point are isolated to |
Member
Rolling didn't had a sync to main for like 6 months now. It's expected to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
Adds support for two additional ROS 2 message types:
foxglove_msgs/msg/CompressedImagefoxglove_msgs/msg/CompressedVideoNew streamer types are available through the existing
typequery parameter:foxglove_compressed_imagefoxglove_compressed_videoThe Foxglove compressed video viewer also supports optional client-side display parameters:
width=<pixels>- set the rendered width while preserving aspect ratio whenheightis not providedheight=<pixels>- set the rendered height while preserving aspect ratio whenwidthis not providedwidth=<pixels>&height=<pixels>- set both rendered dimensions explicitlydisplay_fps=<fps>- limit the browser-side display rate without changing the source stream or server-side encodingExample:
Description
Adds native support for Foxglove compressed image and video message types without requiring conversion to intermediary ROS image message types.
foxglove_msgs/msg/CompressedImagemessages are streamed directly using their existing compressed image payload.foxglove_msgs/msg/CompressedVideomessages are forwarded in their existing encoded form and decoded in the client browser using the WebCodecs API. This avoids decoding, colorspace conversion, scaling, or re-encoding the video on the ROS host and keeps additional server-side CPU overhead low.The H.264 browser path supports Annex-B input as defined by the Foxglove message format and includes handling for:
The implementation is also compatible with the newer
SubscriberFactoryInterfaceAPI added to the ROS 2 branch. The Foxglove streamers retain direct typed ROS subscriptions, similar to the existing compressed-image streamer, while passing the subscriber factory map through the updated streamer interfaces.Client-side scaling and
display_fpsonly affect browser rendering. They do not alter the ROS topic, encoded video stream, network bitrate, or server-side video processing.WebCodecs requires a secure browser context for remote access. In testing, the viewer was served through HTTPS using a reverse proxy while
web_video_serveritself continued to listen over HTTP.This change was developed and tested with H.264 video published through
foxglove_msgs/msg/CompressedVideo, including a GStreamer pipeline usingx264encandh264parse.Closes #206
AI Assistance
These changes were developed with assistance from OpenAI ChatGPT using the GPT-5.6 Sol model. ChatGPT was used to help design the implementation, generate and revise portions of the C++ and browser-side JavaScript, diagnose build and runtime issues, and adapt the implementation to upstream API changes.
The generated changes were built and tested by the contributor, with iterative validation against live ROS 2 Foxglove compressed video streams.