Repository navigation
fix: Restore missing bcp-47 dependencies in package-lock.json - #1302
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
develophas been failing since #1299 (jsdom 30.1.0 → 31.0.0). That also breaks every Dependabot PR based on it, such as #1300.npm cisucceeds, but every vitest worker fails to start:Cause
Two Dependabot PRs merged a minute apart, and their lockfile changes combined into a broken lockfile:
is-alphabetical,is-alphanumericalandis-decimal, which nothing else needed at the time.bcp-47, which depends on those three packages. Its lockfile was generated before Build(deps-dev): Bump changelog-maker from 5.0.0 to 5.1.1 #1297 merged, while they were still present, so it didn't add them.Git merged both changes without a conflict. The result lists
bcp-47without its dependencies. npm treats the lockfile as complete, so neithernpm cinornpm installreports or repairs it.Fix
Removed the
jsdomandbcp-47entries frompackage-lock.jsonand rannpm install --package-lock-onlyin a clean checkout (nonode_modules), so npm resolves that subtree again. This:is-alphabetical@2.0.1,is-alphanumerical@2.0.1andis-decimal@2.0.1^31.0.0rangeNothing else in the lockfile changes. With the fixed lockfile,
npm ciinstalls 708 packages instead of 705, andbcp-47imports correctly.Once this is merged, Dependabot PRs such as #1300 need a rebase to pick it up.
🤖 Generated with Claude Code