Skip to content

fix: Restore missing bcp-47 dependencies in package-lock.json - #1302

Merged
MatthijsBurgh merged 1 commit into
developfrom
fix/lock
Nov 17, 2026
Merged

MatthijsBurgh merged 1 commit into
developfrom
fix/lock

Conversation

@MatthijsBurgh

Copy link
Copy Markdown
Contributor

Problem

CI on develop has been failing since #1299 (jsdom 30.1.0 → 31.0.0). That also breaks every Dependabot PR based on it, such as #1300. npm ci succeeds, but every vitest worker fails to start:

Error: Cannot find package 'is-alphanumerical' imported from node_modules/bcp-47/lib/parse.js

Cause

Two Dependabot PRs merged a minute apart, and their lockfile changes combined into a broken lockfile:

Git merged both changes without a conflict. The result lists bcp-47 without its dependencies. npm treats the lockfile as complete, so neither npm ci nor npm install reports or repairs it.

Fix

Removed the jsdom and bcp-47 entries from package-lock.json and ran npm install --package-lock-only in a clean checkout (no node_modules), so npm resolves that subtree again. This:

  • adds is-alphabetical@2.0.1, is-alphanumerical@2.0.1 and is-decimal@2.0.1
  • moves jsdom from 31.0.0 to 31.0.1, within the existing ^31.0.0 range

Nothing else in the lockfile changes. With the fixed lockfile, npm ci installs 708 packages instead of 705, and bcp-47 imports correctly.

Once this is merged, Dependabot PRs such as #1300 need a rebase to pick it up.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings November 17, 2026 09:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@MatthijsBurgh
MatthijsBurgh merged commit e5ddf73 into develop Nov 17, 2026
14 checks passed
@MatthijsBurgh
MatthijsBurgh deleted the fix/lock branch November 17, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants