Repository navigation
Replace vinca's versioning, pinning, and package lookup logic with py-rattler's - #196
Merged
Merged
Conversation
Contributor
Author
|
this appears to have fixed a bug along the way with version ordering:
|
EzraBrooks
marked this pull request as ready for review
November 9, 2026 22:02
Contributor
|
This conflicts now @EzraBrooks |
get_repodata fetched <channel>/<platform>/repodata.json by hand: its own protocol handling, an MD5-keyed cache in the working directory with a fixed 27-hour lifetime, and callers that each merged "packages" and "packages.conda" themselves. get_channel_records reads the channel with rattler.fetch_repo_data instead, which caches by HTTP semantics and handles zstd-compressed repodata, and returns the records of both artifact types. As before, a channel without (valid) repodata for the platform has no records and an unreachable one raises. vinca-migrate now also sees .conda artifacts.
The newest conda-forge-pinning was found by downloading and decompressing conda-forge's noarch current_repodata.json.zst, an exact version through anaconda.org's release API, and the artifact was unpacked by hand (.conda: zip of tar.zst; .tar.bz2). A rattler.Gateway query for the package reads only its shard of conda-forge's repodata, and rattler.package_streaming.download_and_extract unpacks either format, so vinca no longer depends on zstandard.
The CFEP-9 variant algebra, adapted from conda-smithy, compares pins with conda's VersionOrder upstream but with PEP 440's packaging.Version here. PEP 440 can't parse many pins, which then compare as strings: "3.9.* *_cpython" sorted after "3.10.* *_cpython". vinca-migrate parsed versions by hand instead. rattler.Version orders both as conda does, and vinca no longer depends on packaging.
EzraBrooks
force-pushed
the
py-rattler
branch
from
November 10, 2026 14:27
01cbfa2 to
e868973
Compare
Contributor
Author
|
rebased and resolved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.