Repository navigation
Document that Clear turns copy-on-write off - #596
Merged
Merged
Conversation
Clear resets a bitmap to the state of a new one, which includes turning copy-on-write off. This has been the behavior since copy-on-write was introduced, but it was not documented. State it on Clear in both the 32-bit and 64-bit packages. Xor and AndNot of a 32-bit bitmap with itself called Clear, so they also dropped the copy-on-write setting as a side effect. They now empty the bitmap without changing the setting, as roaring64 Xor already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear()resets a bitmap to the state of a new one, including turning copy-on-write off. This has been the behavior since copy-on-write was introduced (originally*ra = roaringArray{}), but it was not documented. It also matters for bitmaps loaded withFromBuffer, which turns copy-on-write on internally: afterClearthey become ordinary bitmaps again.Changes:
Clear()in bothroaringandroaring64.XorandAndNotof a 32-bit bitmap with itself calledClear(), so they silently dropped the copy-on-write setting. They now empty the bitmap and keep the setting, matchingroaring64.Xor.TestClearResetsCopyOnWriteandTestClearResetsCopyOnWrite64.Supersedes #594.