[cocomarine]

Why?

The old school_management:transfer_ownership rake task destroyed and created Role records by hand. That left no OwnershipTransfer record and sent no emails, so it differed from the (frontend-led) OwnershipTransfer flow that we implemented recently,

It now uses the recent OwnershipTransfer flow instead of editing roles directly.

What's changed?

• It makes the new owner a teacher, then creates an OwnershipTransfer and accepts it straight away.
• Accepting the transfer archives the old owner role instead of destroying it.
• The old owner's teacher role is archived unless keep_old_owner_as_teacher is true.
• It still resets creator_agree_to_ux_contact as before.
• If creating the transfer fails (for example, a pending transfer already exists), the new teacher role is rolled back and the owner is unchanged.
• If the old owner isn't a school owner, it logs an error and exits. Before, this raised a nil error.
• skip_request_email option on OwnershipTransfer and OwnershipTransfer::Create.
  • The task sets it because the request email makes no sense when the transfer is accepted immediately in this flow. The completed emails to the new and previous owners are still sent.

Usage

• Remains the same as before.

# To transfer ownership from Jane to John and REMOVE Jane as a teacher:
bundle exec rails school_management:transfer_ownership[jane.doe@example.com,john.doe@example.com]

# To transfer ownership from Jane to John and KEEP Jane as a teacher:
bundle exec rails school_management:transfer_ownership[jane.doe@example.com,john.doe@example.com,true]

Possible future iteration

• We could add an option for calling OwnershipTransfer::Create and then stopping so that the task is used only for nomination. The nominee (current teacher or newly created teacher) gets the email and accepts on the frontend, following the front-end led flow after the nomination step.
• This will remove the manual process of confirming T&C before the task is run.
• We need to think about things like below:
  • What should requested_by_user_id be? It's required, and the mailers treat it as "the previous owner".
  • Setting it to a support personnel gives a more honest audit trail, but then "previous owner" emails go to support.
  • May need a small schema or mailer tweak, such as a nullable requester or a "requested by support" marker.

Steps to perform after deploying to production

• If necessary, update documentation at https://digital-docs.rpf-internal.org/docs/technology/codebases-and-products/editor/processes/code-editor-for-education/transferring-owners

[github-actions]

Test coverage

94.12% line coverage reported by SimpleCov.
Run: https://github.com/RaspberryPiFoundation/editor-api/actions/runs/40845786195