Repository navigation
Reject invalid DSC resource-body pairings - #2286
Merged
Christoph Bergmeister (bergmeister) merged 3 commits intoOct 28, 2026
Merged
Christoph Bergmeister (bergmeister) merged 3 commits into
Christoph Bergmeister (bergmeister) merged 3 commits into
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code according to review comments
Reject invalid DSC resource-body pairings
Oct 28, 2026
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open issues
What changed in this PR
Updates DSC resource-body detection to avoid incorrectly pairing commands with subsequent script blocks when redirections or semicolon-separated statements are present, ensuring alias corrections still occur as expected.
Changes:
- Reject candidate DSC “resource body” blocks when the candidate scriptblock expression has redirections.
- Reject candidate DSC “resource body” blocks when a semicolon statement separator exists between the command and the following block.
- Add regression test ensuring
gciis still flagged/corrected in the reported edge cases.
| File | Description |
|---|---|
| Tests/Rules/AvoidUsingAlias.tests.ps1 | Adds regression coverage for alias correction when adjacent blocks include redirections or are separated by semicolons. |
| Rules/AvoidAlias.cs | Tightens DSC AST fallback pairing logic by rejecting redirection-bearing blocks and semicolon-separated statements. |
Review effort: Lite
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 28, 2026 20:14
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 28, 2026 20:14
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2287
October 28, 2026 20:14
Christoph Bergmeister (bergmeister)
merged commit Oct 28, 2026
aeccd61
into
copilot/fix-auto-correct-aliases
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-comments-in-review-thread
branch
October 28, 2026 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fallback DSC AST detection could pair executable commands with following blocks, suppressing expected
Get-corrections when the block had redirections or a semicolon separated the statements.Get-ChildItemcorrections.{ gci . {} > $null gci .; {} }