Skip to content

Preserve tab indentation when formatting branches - #2275

Merged
Christoph Bergmeister (bergmeister) merged 2 commits into
copilot/ignore-onelineblock-correctionfrom
copilot/fix-comments-in-review-thread-2262
Oct 28, 2026
Merged

Christoph Bergmeister (bergmeister) merged 2 commits into
copilot/ignore-onelineblock-correctionfrom
copilot/fix-comments-in-review-thread-2262

Conversation

Copilot AI commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

When formatting a closing brace followed by a branch, synthesized spaces could misalign the branch if the brace line used tabs. Preserve the brace line’s actual leading whitespace.

  • Change: Use the source indentation when moving the branch to a new line.
  • Example:
if ($true) {
    $true
	}	else {
	    $false
	}

The formatted else now retains the closing brace’s tab indentation.

Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix code for all comments in review thread Preserve tab indentation when formatting branches Oct 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the change preserving tab indentation when moving branch keywords onto a new line.

No open issues 🎉

What changed in this PR

Preserves tab indentation when the formatter moves a branch keyword onto a new line after a closing brace.

Changes:

  • Reuses the brace line’s original leading whitespace instead of generating spaces.
  • Adds a regression test confirming that else retains the closing brace’s tab indentation.
File Description
Tests/​Rules/​PlaceCloseBrace.tests.ps1 Tests preservation of tab indentation when moving else to a new line.
Rules/​PlaceCloseBrace.cs Copies source indentation for a closing brace on its own line.

Review effort: Balanced

@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review October 28, 2026 12:31
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 7b3de72 into copilot/ignore-onelineblock-correction Oct 28, 2026
8 checks passed
@bergmeister
Christoph Bergmeister (bergmeister) deleted the copilot/fix-comments-in-review-thread-2262 branch October 28, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants