Repository navigation
Handle arrays and casts in ValidateRange type-mismatch warnings - #2273
Merged
Christoph Bergmeister (bergmeister) merged 3 commits intoOct 28, 2026
Conversation
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comments
Handle arrays and casts in ValidateRange type-mismatch warnings
Oct 28, 2026
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2274
October 28, 2026 12:11
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the expanded range-type detection and mixed-bound exclusions.
No open issues 🎉
What changed in this PR
Updates AvoidValidateRangeTypeMismatch to detect integral range bounds on floating-point and decimal array parameters and cast expressions, while avoiding mixed-bound false positives.
Changes:
- Resolve parameter and cast types through reflection, including aliases, and inspect array element types.
- Require both range bounds to be integral before warning.
- Add regression cases for arrays, casts, aliases, and mixed bounds.
| File | Description |
|---|---|
| Tests/Rules/AvoidValidateRangeTypeMismatch.tests.ps1 | Adds regression coverage for expanded detection and mixed-bound exclusions. |
| Rules/AvoidValidateRangeTypeMismatch.cs | Updates type resolution, array handling, and boundary checks. |
Review effort: Balanced
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 28, 2026 12:15
Christoph Bergmeister (bergmeister)
requested a review
from a team
as a code owner
October 28, 2026 12:15
Collaborator
|
Copilot why not keep existing test case for decimal type? |
Christoph Bergmeister (bergmeister)
marked this pull request as draft
October 28, 2026 12:17
Co-authored-by: bergmeister <9250262+bergmeister@users.noreply.github.com>
Contributor
Author
The prior decimal case used mixed bounds ( |
Christoph Bergmeister (bergmeister)
removed this pull request from stack #2277
October 28, 2026 12:31
Christoph Bergmeister (bergmeister)
marked this pull request as ready for review
October 28, 2026 12:31
Christoph Bergmeister (bergmeister)
merged commit Oct 28, 2026
117fa6b
into
copilot/validate-range-boundary-check
8 checks passed
Christoph Bergmeister (bergmeister)
deleted the
copilot/fix-code-for-comments
branch
October 28, 2026 13:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integral
ValidateRangebounds can allow out-of-range fractional values ondouble,single, anddecimalparameters. The warning now covers array parameters and cast bounds while avoiding mixed-bound false positives.