Repository navigation
Filter Install-PSResource runtime assets by RID - #2074
Draft
Justin Chung (jshigetomi) wants to merge 1 commit into
Draft
Justin Chung (jshigetomi) wants to merge 1 commit into
Justin Chung (jshigetomi) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
10 of 16 tasks
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Reintroduces only the runtime identifier (RID) filtering portion of #1963 after the combined RID/TFM change was reverted by #2070 because of a TFM filtering bug.
-RuntimeIdentifiertoInstall-PSResource, including argument completion.win-x64/...andlinux-x64/....runtimes/{rid}/...content and alllib/{tfm}/...content untouched.ParentInstallWorkItem, and existing files are not overwritten.Validation:
.\build.ps1 -Clean -Build -BuildConfiguration Debug -BuildFramework net472— passed..\test\RIDFilteringTestswith tagCI— 27 passed, 0 failed..\test\RIDFilteringTestswith tagCI— 27 passed, 0 failed.Invoke-ScriptAnalyzer -Path .\test\RIDFilteringTests -Recursewith PSScriptAnalyzer 1.25.0 — passed with no findings.Install-PSResource TestModuleWithDependencyC -Version 1.0.0.0under PowerShell 7 — passed; expected dependencies were installed.PR Context
This draft is the standalone RID-only extraction requested after #2070. It deliberately excludes every TFM/lib filtering and TFM-aware dependency-group change from #1963. It also does not broaden filtering to the standard NuGet
runtimes/{rid}/...layout.Tooling impact is limited to the new public
Install-PSResource -RuntimeIdentifierparameter and its argument completer.PR Checklist
WIP:orDo not merge:to the PR title and do not check this box.Install-PSResourceMicrosoftDocs/PowerShell-Docs-PSGet#347