Skip to content

Update to version 3.4-preview.3 and crate versions - #1781

Merged
Steve Lee (SteveL-MSFT) merged 2 commits into
PowerShell:mainfrom
SteveL-MSFT:3.4-p3
Oct 30, 2026
Merged

Steve Lee (SteveL-MSFT) merged 2 commits into
PowerShell:mainfrom
SteveL-MSFT:3.4-p3

Conversation

@SteveL-MSFT

Copy link
Copy Markdown
Member

PR Summary

  • Update version to 3.4-preview.3
  • Update crate versions
  • Fix some code due to breaking change in new sysinfo crate version

Copilot AI balanced review requested due to automatic review settings October 29, 2026 22:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The sysinfo 0.40 upgrade breaks Windows compilation because check_store() calls process() on the unhandled Result returned by System::new_with_specifics.

1 open issue
What changed in this PR

Updates DSC to 3.4.0-preview.3, refreshes Rust dependencies, and adapts process inspection code to the new sysinfo API.

Changes:

  • Bumps the DSC package version and updates dependency requirements and lockfile entries.
  • Handles fallible system initialization in process listing and Ctrl+C handling.
  • Adds a localized error message for system-information failures.
File Description
resources/​process/​src/​main.rs Updates process initialization and propagates failures.
dsc/​src/​main.rs Handles system initialization failure during Ctrl+C cleanup.
dsc/​locales/​en-us.toml Adds the system-information error message.
dsc/​Cargo.toml Bumps DSC to 3.4.0-preview.3.
Cargo.toml Updates workspace dependency versions.
Cargo.lock Records updated package versions and dependency resolution.

Review effort: Balanced

Comment thread Cargo.toml Resolved
@SteveL-MSFT
Steve Lee (SteveL-MSFT) merged commit b450a1c into PowerShell:main Oct 30, 2026
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants