Repository navigation
Fix OSInfo assertions and tests for rolling-release distributions - #1778
Merged
Steve Lee (SteveL-MSFT) merged 3 commits intoOct 28, 2026
Merged
Steve Lee (SteveL-MSFT) merged 3 commits into
Steve Lee (SteveL-MSFT) merged 3 commits into
Conversation
3 tasks done
Co-authored-by: SteveL-MSFT <11859881+SteveL-MSFT@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix version operators and codename issue for Arch Linux in OSInfo
Fix OSInfo assertions and tests for rolling-release distributions
Oct 28, 2026
Steve Lee (SteveL-MSFT)
marked this pull request as ready for review
October 28, 2026 18:28
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The test’s -Skip:$skip is evaluated before per-case variables are available, so Rolling Release cases still run and fail on Arch Linux.
1 open issue
What changed in this PR
This PR addresses #1777 by correcting OSInfo state comparisons for missing properties and adapting tests for rolling-release distributions.
Changes:
- Treat requested-but-unreported OS properties as not in the desired state.
- Add conditional skips for version-operator and codename tests while retaining literal version matching.
- Add deterministic missing-property and rolling-release tests, plus a CLI assertion for absent codenames.
| File | Description |
|---|---|
resources/osinfo/tests/osinfo.tests.ps1 |
Adds platform-dependent skip conditions and absent-codename assertions. |
lib/dsc-lib-osinfo/src/lib.rs |
Extracts state comparison logic, rejects missing requested properties, and adds regression tests. |
Review effort: Balanced
Co-authored-by: SteveL-MSFT <11859881+SteveL-MSFT@users.noreply.github.com>
😲 Code Coverage ReportChanged Code Coverage100% (100% coverage)
🔵 Full Codebase Coverage83% (good)
|
Steve Lee (SteveL-MSFT)
approved these changes
Oct 28, 2026
Steve Lee (SteveL-MSFT)
deleted the
copilot/fix-osinfo-version-operators-arch-linux
branch
October 28, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Arch Linux, non-numeric versions and absent codenames cause OSInfo test failures. Requested properties missing from the actual OS state also incorrectly report success.