Repository navigation
(GH-1081) Integrate settings through CLI and lib - #1769
Draft
Mikey Lombardi (He/Him) (michaeltlombardi) wants to merge 2 commits into
Draft
Mikey Lombardi (He/Him) (michaeltlombardi) wants to merge 2 commits into
Mikey Lombardi (He/Him) (michaeltlombardi) wants to merge 2 commits into
Conversation
Mikey Lombardi (He/Him) (michaeltlombardi)
force-pushed
the
gh-1081/main/settings-plumbing
branch
4 times, most recently
from
October 29, 2026 20:17
573f306 to
80a2110
Compare
This change continues the work for using structured settings for DSC. This change: - Defines a globally accessible static for performantly accessing and using the resolved settings. - Replaces ad-hoc settings access with accessing the global static. - Updates the `--ignore-settings-file` argument so users can negate the flag and override the environment variable.
Prior to this change, some of the csp integration tests failed when run in a non-elevated context. This change: - Guards the test behavior on whether the current context is elevated. - Uses `test_case` to treat each test case in the tests as separate tests instead of failing the entire test when one case fails.
Mikey Lombardi (He/Him) (michaeltlombardi)
force-pushed
the
gh-1081/main/settings-plumbing
branch
from
October 29, 2026 22:01
80a2110 to
70decef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This change continues the work for using structured settings for DSC. This change:
--ignore-settings-fileargument so users can negate the flag and override the environment variable.PR Context
Continues the work from #1081