Repository navigation
Rework the sidebar so mod pages fit - #1322
Merged
Merged
Conversation
Wyvest
reviewed
Nov 10, 2026
| } | ||
| } | ||
| NotificationBell() | ||
| Row(horizontalArrangement = Arrangement.spacedBy(14.dp), verticalAlignment = Alignment.CenterVertically) { |
Member
There was a problem hiding this comment.
Long player names leave too little width for both icons, so the bell gets clipped. Reserve the icon width and constrain/ellipsize the name.
| val title = it.title | ||
|
|
||
| NavigationSection(it.title) { | ||
| NavigationSection(title, collapsed = SidebarCollapse.isCollapsed(title), onToggle = { SidebarCollapse.toggle(title) }) { |
Member
There was a problem hiding this comment.
Collapse state is keyed by the translated title, so groups with the same title share it. Key it by PageGroup.id.
| Text( | ||
| translated("oneconfig.sidebar.more", "+%s more", hidden), | ||
| modifier = Modifier.padding(start = 26.dp, top = 6.dp) | ||
| .onClick(source) { scope.launch { scroll.animateScrollTo(scroll.maxValue) } } |
Member
There was a problem hiding this comment.
"+N more" still animates the scroll with Reduced Motion on. Use scrollTo in that mode.
| val route = pageRoute(page) | ||
| NavigationEntry(page.icon, page.title.resolve(), route, entry.isOn(route)) { | ||
| expanded = false | ||
| shell.navigation.navigate(route) |
Member
There was a problem hiding this comment.
Selecting Changelog while already on it no longer clears its search: navigate returns early for the current route. Clear the search here the same way the sidebar does for the current route.
Wyvest
requested changes
Nov 10, 2026
Wyvest
left a comment
Wyvest
left a comment
Member
There was a problem hiding this comment.
See the inline comments above. Also needs a rebase: merge conflict in ThemeConfig.java.
Deftu
force-pushed
the
feat/sidebar-cleanup
branch
2 times, most recently
from
November 10, 2026 06:12
09f2f0e to
88d3266
Compare
Deftu
force-pushed
the
feat/sidebar-cleanup
branch
from
November 10, 2026 06:41
88d3266 to
f0d8300
Compare
Deftu
force-pushed
the
feat/sidebar-cleanup
branch
from
November 10, 2026 07:20
f0d8300 to
534097e
Compare
Wyvest
force-pushed
the
feat/sidebar-cleanup
branch
from
November 10, 2026 07:21
534097e to
305a990
Compare
Deftu
force-pushed
the
feat/sidebar-cleanup
branch
from
November 10, 2026 07:27
305a990 to
eda24c1
Compare
Deftu
force-pushed
the
feat/sidebar-cleanup
branch
from
November 10, 2026 07:34
eda24c1 to
e21eefa
Compare
Deftu
force-pushed
the
feat/sidebar-cleanup
branch
from
November 10, 2026 07:35
e21eefa to
2e69d4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar sections fold, the page list scrolls with a "+N more" hint, and Edit HUD always sits at the bottom.
Changelog and Credits move to an info button next to the bell, and the "Sidebar Buttons at Bottom" option is gone.
Tested on 26.3 only.