Repository navigation
Conversation
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. The line 7 floor reproduces all five rows of the department's table (2025 MO-1040 instructions), which also settles that nonbusiness losses are stacked last. Military retired pay and U.S. obligation interest are each added back once against Missouri AGI, mo_ssp and general_assistance add no cycle, and the new expected values check by hand. Three fixes before I approve.
Before merge
- Partnership and S corporation losses are business losses.
nonbusiness_loss_sources.yamllistspartnership_s_corp_income, so a K-1 ordinary business loss is added back on line 7. RSMo 135.010(5)(d) adds back only "losses not incurred in a trade or business", and the instructions define a nonbusiness loss as one that "did not result from a trade or business" (same page). A partner's or shareholder's share keeps the entity's trade-or-business character (IRC 702(b), 1366(b)), and no Missouri source treats Schedule E business losses as nonbusiness. Please drop that entry, update the two cases that use it (mo_ptc_gross_income.yamllines 119 and 215), and narrow the candidate entry to rental, farm rent and estate losses, which are a reasonable fill. - A dependent's line 3 items now count.
military_retirement_pay,us_govt_interest_personandtax_exempt_retirement_distributionsare summed over every tax-unit member, while a dependent's Missouri AGI is zeroed. "Income" is the claimant's, and the spouse's on a combined return (135.010(1), (5)). MO-PTS brings in minor children only on lines 2 and 6; line 3 measures amounts "not included on Form MO-1040, Line 6", which is the claimant's own return. So a grandchild's 600 of savings bond interest counts while the same child's 600 of bank interest does not. Please apply thenot_dependentmask you already use on line 7 to these three sources.tax_exempt_pension_incomeandtax_exempt_interest_incomehave the same problem on main, so masking them too keeps line 3 consistent. - Register the conflicts the PR body names. CONTRIBUTING ("Source conflicts", step 1) asks for a
source_conflicts/candidates.yamlentry when a PR takes a reading. Three are missing: child support (counted per form line 6, but not listed in 135.010(5)); the excludable cost of pensions (5(b) counts "the total amount", while the line 3 instruction excludes it), which now also coverstax_exempt_retirement_distributions; and how far the 5(a) "unless" clause reaches. The new entry also needsprs:.
Optional
- Line 7 tests. Add one case where a Schedule C loss and a capital loss push federal AGI below zero, and one with a dependent's rental loss. A one-line comment that nonbusiness losses are stacked last would also help.
public_assistance_types.yamlstill saysunit: currency-USD. Since the file is already open, it could change tounit: list.
c15af23 to
a2ac762
Compare
|
Thanks, Ziming. Fixed in a2ac762, rebased on main. I updated the PR body to match. Fixed (your "Before merge" items)
Skipped (optional, not in this round):
Verification:
|
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. All three items are fixed. Partnership and S corporation losses stay deducted, and the two reworked cases check by hand at 18,000 and −269,000. The not_dependent mask covers all five line 3 sources, and the savings-bond grandchild case gives 20,000. The three new entries quote RSMo 135.010(5), the 2025 MO-PTS and the instructions accurately, and every entry has prs:. One register fix before I approve.
Before merge
-
us-mo:property-tax-credit-veteran-exception-scopeis labelledgap-fill, but its reading says the code departs from the statute. The legend at the top ofcandidates.yamlusesgap-fillfor a statute that is silent. This entry's statute reading says "Read literally, the clause follows all three kinds of benefits", and the code counts Social Security, which isconflicting-sourceby that legend. Please either:- set
follows: conflicting-source, or - give both statutory readings and say the department breaks the tie, as
us-la:dependent-exemption-of-a-claimable-filer-with-filing-exceptiondoes for itsgap-fill. Under the last-antecedent rule, the "unless" clause modifies only "veterans payments and benefits", and the next sentence ("shall not be required to list veterans payments and benefits") supports that reading.
The entry stays
unreviewedeither way; the project lead rules on the substance. - set
Optional
- The new 2023 rental-loss case. Section 461(l) limits only trade or business losses, which the PR now keeps deducted, so a 461(l)-limited rental loss is something the model can produce but federal law can't. A comment saying the case exercises the model's 461(l) share code would help. Also, its SSI is zero because of the $10,000 bank balance, not the pension the file header credits.
- From the first round, still open: the extra line 7 tests and the stacking comment, and
unit: listonpublic_assistance_types.yaml. - Open PR 10722 edits both of this PR's Missouri files, so whichever merges second will need to reconcile them.
Household income for the Missouri property tax credit (Form MO-PTS) now adds back military retirement benefits, interest on U.S. obligations and tax-exempt retirement account distributions that Missouri AGI leaves out, counts general assistance and Missouri state supplementary payments as public assistance, and adds back rental, farm rental, estate and partnership losses with the net capital loss deduction (RSMo 135.010(5)). From 2024, when a negative federal AGI enters Missouri AGI as zero, only the part of a nonbusiness loss that brought federal AGI down to zero is added back (#10922). When the claimant or spouse is a 100 percent service-connected disabled veteran, no member's veterans benefits count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ependents' line 3 items, register three Missouri readings Drop partnership and S corporation losses from the nonbusiness loss add-back list, since they keep the entity's business character and stay deducted. Count Form MO-PTS line 3 pensions, retirement distributions and exempt interest only for the claimant and spouse, not dependents. Register the child support, pension excludable cost and veteran exception scope readings in the source conflicts file. Tests and the changelog fragment are updated to match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…h readings Record the literal and last-antecedent readings of the RSMo 135.010 veteran exception in source_conflicts/candidates.yaml, note that the department's form breaks the tie, and clarify the rental-loss test comments on section 461(l) and the 2023 SSI case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a2ac762 to
ac797d3
Compare
|
Thanks, Ziming. Fixed in ac797d3, rebased on main. Fixed (your "Before merge" item)
Also done (your optional item): the 2023 rental-loss case now says that section 461(l) limits only trade or business losses, so the case exercises the model's 461(l) share code. Its header credits the $10,000 bank balance, not the pension, for zero SSI. Without that balance, SSI would be $10,968. No inputs or expected values changed. Skipped (optional, not in this round): the extra line 7 tests and stacking comment, and Verification: after the rebase, the Missouri property tax credit directory (76) and the source-conflict tests (251) pass locally. An independent check confirmed the entry against the Louisiana pattern and the legend. |
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. The veteran-exception entry now gives both readings of 135.010(5)(a), the literal one and the last-antecedent one the next sentence supports, and it says the department breaks the tie, so gap-fill now fits. It stays unreviewed with no ruling recorded. The rental-loss case comments now explain the 461(l) scenario and the SSI result. Nothing else changed. Approving.
Part of #10812 (state credit income audit).
Fixes #10922.
What was wrong
mo_ptc_gross_incomeis household income for the Missouri property tax credit (Form MO-PTS, line 8). RSMo 135.010(5) defines it as Missouri AGI "increased, where necessary," by items (a) to (e). The model left out several of those items, added back too much of a capital loss when federal AGI fell below zero, and still counted a spouse's veterans benefits when the other spouse was a 100 percent service-connected disabled veteran.What changes
Each rule below is checked against RSMo 135.010(5), Form MO-PTS 2025 (lines 1-5 on PDF page 1, lines 6-8 on page 2), and the 2025 MO-1040 instructions for Form MO-PTS, page 18.
military_retirement_pay, the input the model subtracts from Missouri AGI (agi_subtractions.yaml).us_govt_interest_person, the amount Missouri AGI subtracts.tax_exempt_retirement_distributions(Roth IRA, 401(k), 403(b) and SEP).general_assistanceandmo_ssp(replacing the commented-outmo_state_supplement) topublic_assistance_types.yaml.nonbusiness_loss_sources.yaml. When section 461(l) disallows part of these losses, only the deducted share is added back. Schedule C and F losses stay deducted, and so do partnership and S corporation losses: a partner's or shareholder's share keeps the entity's trade-or-business character (IRC 702(b), 1366(b)).federal_agi.negative_floor_appliesis true (2024 on), line 7 ismin(losses, max(0, federal AGI + losses)). This gives the department's line 7 amount in all five table rows. Through 2023, Missouri AGI can be negative and the whole loss is added back.military_retirement_pay,us_govt_interest_person,tax_exempt_retirement_distributions,tax_exempt_pension_incomeandtax_exempt_interest_incomecount only for the head and spouse, with the samenot_dependentmask line 7 uses.is_fully_disabled_service_connected_veteran, no member'sveterans_benefitscount. Otherwise a 100 percent veteran's own benefits still don't count, as before.The variable's references now include the 2025 form, instructions and Form MO-A with page anchors. The existing 2021 references stay.
Source-conflict candidates
RSMo 135.010 doesn't define "trade or business". A rental activity can be a trade or business in federal usage, while the department treats only Schedule C and F losses as business losses. For rental, farm rental and estate losses the code follows the department's line, so this PR records
us-mo:property-tax-credit-nonbusiness-lossinsource_conflicts/candidates.yamlas a gap-fill (stateunreviewed). Partnership and S corporation losses are not part of it: they keep the entity's trade-or-business character, and no Missouri source treats them as nonbusiness. If the ruling goes the other way, removing entries fromnonbusiness_loss_sources.yamlis enough.Three more readings are recorded the same way (all
unreviewed, from 2021):us-mo:property-tax-credit-child-support: the form counts child support on line 6, but it is not among the statute's items (a) to (e). The model follows the form.us-mo:property-tax-credit-veteran-exception-scope: how far the 135.010(5)(a) "unless" clause reaches (see the open questions below).us-mo:property-tax-credit-pension-excludable-cost: the statute's "total amount" of pensions against the line 3 instruction that excludes their cost. The model follows the statute, fortax_exempt_retirement_distributionstoo.Who is affected
Missouri property tax credit claimants (65 or older, 100 percent disabled, or 60 or older receiving surviving spouse Social Security). The credit is refundable.
Tests
Moved from #10812 (
mo_ptc_gross_income_audit.yaml) intomo_ptc_gross_income.yaml, without the audit framing: military retirement benefits (15,000 to 35,000), U.S. obligation interest (20,000 to 23,000), general assistance (20,000 to 22,400), rental loss (14,000 to 20,000), tax-exempt 401(k) distribution (20,000 to 24,000), and the spouse of a 100 percent disabled veteran (26,000 to 20,000).Added to
mo_ptc_gross_income.yaml:Added to
mo_property_tax_credit.yaml: the #10922 renter end to end, household income 15,000 and a 709 credit, the department's 2025 chart cell for 14,901-15,200 and 726-750.No existing expected value changed. The existing 2021 case (head is a 100 percent disabled veteran, child has Social Security, SSI and TANF) still gives 29,000.
Open questions from the review (registered as candidates, behavior not changed here)
tax_exempt_pension_incomein full, following the statute, and now addstax_exempt_retirement_distributionsin full too. Under the department's reading the contribution basis of a Roth distribution, or the nondeductible basis of a traditional IRA distribution, would be left out. No input separates basis from earnings.Not in this PR
The other Missouri items in the #10812 audit:
us-mo:property-tax-credit-child-support).After the review fixes, tested locally:
mo_ptc_gross_income.yaml(19), the Missouri property tax credit directory (76),test_source_conflicts.py(251) and the military retirement readers and parameter YAML key checks (38) all pass. Before them, tested on Modal: runw1-mo-b, 253/253 passed (the Missouri test folder, every partner test, and five code-health checks: source conflicts, parameter YAML keys, reference URLs, concatenated reference URLs and military retirement readers).🤖 Generated with Claude Code