Repository navigation
Count the whole household's income for New York's real property tax credit - #11170
Conversation
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. Household gross income now matches Tax Law 606(e)(1)(B)-(C) and the 2024 IT-214: the federal AGI of every household member plus the listed items, with no double counting and no cycle from the new TANF and State Supplement reads. Only ny_real_property_tax_credit reads it, through 2024, and no existing case's inputs changed. One fix before I approve.
Before merge
-
The credit's other inputs are still the tax unit's.
ny_real_property_tax_credit.pyreads rent and the age tier per tax unit (lines 21-34 and 72-74) while income is now the household's. In two-return households that moves the result further from the statute than main (hand traces, not run):- Parent aged 70 on their own return with 12,000 of Social Security; adult child aged 40 with 3,000 of wages, paying 4,800 of rent. Statute: 112.50, since 606(e)(6)(A) gives the household the 65-or-older limit. Main: 71. This PR: 47.
- Two adults on their own returns, 8,000 of wages each, each paying 2,400 of a 4,800 rent. Statute: one credit of 45 on the household's rent (IT-214 line 19, "rent you and all members of your household paid"). Main: 61 on each return. This PR: 0 on each.
Please move the renter's rent and the age tier to the household in this PR, or tell me if you would rather hold the income change until they can move together.
Optional
- Two statutory items with inputs. 606(e)(1)(C) names "nontaxable strike benefits" and takes AGI with the section 612(b) modifications (IT-214 line 10).
tax_exempt_strike_benefitsandny_additionsboth exist and are outside federal AGI. - Line 11 conflict. The instruction nets Medicare premiums from Social Security; the statute counts the gross amount. The model follows the statute, but the PR's quote stops before that clause and there is no
source_conflicts/candidates.yamlentry. - Safety Net Assistance. Line 14 reads
general_assistancebut notny_safety_net_assistance, New York's own input. Reading both could double count, so it needs one choice or a sentence of documentation. - Tests. No pre-2025 joint-return case, no cross-unit loss case (the PR body's "never falls" is wrong when another member's AGI is negative) and no case with rent on two tax units.
- "Not yet added" list. It omits railroad retirement, excluded gain, foster care payments and part-year membership. Open PR 10722 edits the same variable for railroad benefits.
8198e98 to
1ad017e
Compare
|
Thanks, Ziming. I took your first option and moved rent and the age tier to the household in this PR, with one credit per household. Fixed in 1ad017e, rebased on main. Fixed (your "Before merge" item) Through 2024 (the years
Your two traces are now tests (2024):
A new claimant test file covers three more cases: the homeowner's unit wins (137), a tie goes to the household head (45), and in 2025 each unit claims its own (70 and 70). I also pointed the Skipped (optional, not in this round): strike benefits and the 612(b) modifications, the line 11 Medicare entry, the Safety Net Assistance choice, the extra tests and the "Not yet added" list. One thing left as is: line 7 of the 2024 IT-214-I names a 65+ member "who is filing Form IT-214", while the code follows p. 1 and counts any 65+ household member. That could become a register entry. Verification: the NY credits tests pass locally after the rebase (304/304), as do the source-conflicts and NY claimable-filer tests. An independent check confirmed both traces and the claimant cases by hand, and the IT-214-I quotes. It also ran a combined six-household simulation, including a three-unit household whose head's unit is ineligible. |
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. The household fix holds against 606(e) and the 2024 IT-214 and IT-214-I. Through 2024, rent and the 65-or-older limit come from the whole household, property tax and assessed value stay with the owner's tax unit, and only one tax unit claims. The claimant order (largest potential, then household head, then person order) is a division the members could agree to, and the potential never reads the claimant. Both traces are now tests (112.50 and 45), the five new expected values derive by hand, and 2025 on matches main. One small fix before I approve.
Before merge
- Record the line 7 reading. You flagged it yourself: the code follows 606(e)(6)(A) ("able to meet the qualifications of a qualified taxpayer and one of them is sixty-five") and IT-214-I page 1 ("at least one member"), while line 7 of the 2024 instructions limits the elderly limit to a 65+ member "who is filing Form IT-214". It only changes money when the 65+ member is a claimed dependent, who can't file a claim. Example: an adult child (40, wages 3,000, rent 4,800) who claims a 70-year-old parent with 12,000 of Social Security gets 112.50 under the statute and 47 under line 7. Keeping the statute is right; please add a
source_conflicts/candidates.yamlentry and a 2024 case with that household.
Optional
- Rent paid inside an owner-occupied household. Every tax unit's potential adds household rent and tests it against the $450-a-month tenant cap, so rent a member pays to the owning member joins the owner's claim. A parent (70) who owns with 1,500 of property tax, and an adult child on their own return paying the parent 500 a month, now gets 0, where the owner's own computation gives 137. 606(e)(7)(D) bars only "a tenant", and that rent isn't paid "for the right of occupancy" by the household. It only arises if the child's payment is entered as
rent. - References.
ny_real_property_tax_credit_potential.pylists the 2024 IT-214-I twice (#page=1and#page=2), andny_real_property_tax_credit_claimant.pycites page 1 while its comment relies on line 33 (page 3). uses_household_gross_incomenow also switches household rent, the age limit and the one-credit rule; its description mentions only income.- Claimant code. It copies the Arizona claimant line for line; Montana and Utah have the same rule, so a shared helper could serve all four.
- Still open from the first round: strike benefits and the 612(b) additions, the line 11 Medicare conflict,
ny_safety_net_assistance, a pre-2025 joint return and a cross-unit loss case, and the "Not yet added" list.
…redit IT-214 household gross income (used through 2024) now sums every member of the household, including other tax units and dependents' own AGI, and adds workers' compensation, child support, veterans' benefits, tax-exempt pensions, TANF, general assistance, State Supplement Program payments, tax-exempt disability benefits and section 911 excluded income, per Tax Law 606(e)(1)(B)-(C) and the 2024 IT-214 lines 9 to 15. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… real property tax credit, one credit per household Through 2024 the credit now counts rent paid by every household member, applies the 65-or-older limit when any household member is 65 or older, and allows one credit per household (Tax Law 606(e)(1)(F)(i), 606(e)(6)(A)). New ny_real_property_tax_credit_potential holds the per-unit amount and ny_real_property_tax_credit_claimant picks the one claiming tax unit; every tax unit still claims from 2025. Points the source-conflict candidate us-ny:real-property-credit-claimable-spouse at the potential variable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n aged dependent Register candidate us-ny:real-property-credit-aged-dependent for the 2024 rule that only a household member filing Form IT-214 counts on line 7, mark the pre-2025 age test with the candidate comment, and add a 2024 case where an aged parent claimed as a dependent gives the household the elderly limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1ad017e to
9bee87d
Compare
|
Thanks, Ziming. Fixed in 9bee87d, rebased on main. Fixed (your "Before merge" item)
Skipped (optional, not in this round): rent a member pays to the owning member, the duplicate IT-214-I reference and claimant page cite, the Verification: the NY credits tests (305/305) and the source-conflicts and dead-URL tests (291/291) pass locally after the rebase. An independent check confirmed the entry's quotes against IT-214-I pages 1-3 and the 606(e) text, and the 112.50 by hand. |
hua7450
left a comment
There was a problem hiding this comment.
Thanks, David. Both items are in. The us-ny:real-property-credit-aged-dependent entry quotes 606(e)(6)(A) and IT-214-I page 1 against line 7 and the line 32 chart, follows the statute, and is open with this PR. The new 2024 case with a claimed 70-year-old parent comes to 112.50, which I checked by hand: 1,200 − 975 = 225, half is 112.50, under the $137 elderly limit. Apart from that commit, the rebase changed nothing in the PR's diff. Approving.
Part of #10812 (state credit income audit).
What was wrong
ny_household_gross_incomeis the income measure for New York's real property tax credit (Form IT-214) through tax year 2024; from 2025 the credit uses federal AGI. The variable's own documentation admitted two problems:veterans_benefitstax_exempt_pension_incometanf_person,general_assistance,ny_sspworkers_compensationchild_support_receivedtax_exempt_disability_benefitssection_911_excluded_incomeI read the 2024 IT-214 and IT-214-I on tax.ny.gov directly. The statute text is from nysenate.gov.
What changes
ny_household_gross_incomenow builds lines 9 to 15 per person and sums them over the PolicyEngine household; every tax unit in the household gets that total.ny_recomputed_federal_agicounts once, on its head, plus each tax unit dependent'sdependent_adjusted_gross_income.dependent_taxable_social_security(which their own AGI holds), so a dependent's Social Security counts once. Plusveterans_benefits.tanf_person(each member's equal share), which sums back to the unit's TANF over the household.section_911_excluded_incomeis a tax unit amount and counts on the head.person.household.sum, then the tax unit's members); nothing is mapped throughmap_to.Unrelated roomers. 606(e)(1)(B) leaves out "a tenant, subtenant, roomer or boarder who is not related to the qualified taxpayer". The model can't tell them apart: no input marks a member as a tenant, roomer or boarder. (
is_related_to_head_or_spouseisn't enough, because an unrelated member who shares the home is still a household member.) So their income counts. The documentation says so.Who is affected
Only tax years through 2024, and only New York filers near the credit's $18,000 household gross income limit. Household gross income rises (never falls) for:
For them the real property tax credit falls or ends, so New York income tax rises (or the refund falls). Nothing changes from 2025, when the credit keys on federal AGI.
Tests
Moved from #10812 (
ny_household_gross_income_audit.yaml) intony_household_gross_income.yaml, with the "Main:" values and audit framing dropped:Added in
ny_household_gross_income.yaml:Added in
ny_real_property_tax_credit.yaml(2024, at the $18,000 limit and one dollar above):Changed in
ny_real_property_tax_credit.yaml:ny_household_gross_income13,316 → 13,592. The aged dependent's State Supplement Program payment for living with others, 23 × 12 = 276, now counts on line 14. The credit stays 154: rate 0.06, threshold 815.52, 50% of the 9,184.48 excess is 4,592.24, capped at the 13,001-14,000 elderly maximum of 154.Not in this PR
Other New York real property tax credit gaps from the #10812 audit, left for later:
ny_other_additions).Rent, age and one credit per household (added after review): through 2024 the credit also uses the rent paid by all household members (2024 IT-214 line 19) and the 65-or-older limit when any household member is 65 or older (606(e)(6)(A)), and only one tax unit per household receives it (2024 IT-214-I, page 1, and the line 33 instructions, page 3).
ny_real_property_tax_credit_potentialcomputes each tax unit's credit on household amounts, andny_real_property_tax_credit_claimantgives it to the tax unit with the largest potential credit, then the household head's, then person order. Property tax and assessed value stay with the tax unit that owns the home (606(e)(1)(E)). From 2025 each tax unit's credit is unchanged.Tested on Modal: run
w1-ny-a, 255/255 passed: 253 YAML test files (every New York test, all partner files, and the Yonkers, local-tax and abolish-federal-income-tax files that read New York income tax) and 2 pytest files (test_source_conflicts.py,test_claimable_filer_ny_invariants.py). No partner test changed.🤖 Generated with Claude Code